Skip to content

[DowngradePhp80] Add DowngradeReflectionClassGetConstantsFilterRector #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Dec 20, 2021
Merged

[DowngradePhp80] Add DowngradeReflectionClassGetConstantsFilterRector #1529

merged 33 commits into from
Dec 20, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik force-pushed the add-downgrade-reflection-class-get-constants-filter branch from 3352034 to 3fe62a6 Compare December 19, 2021 14:41
@samsonasik samsonasik force-pushed the add-downgrade-reflection-class-get-constants-filter branch from fad0a87 to c6b8f39 Compare December 19, 2021 15:37
@samsonasik samsonasik force-pushed the add-downgrade-reflection-class-get-constants-filter branch from 8225877 to 98e436b Compare December 19, 2021 15:58
@samsonasik samsonasik force-pushed the add-downgrade-reflection-class-get-constants-filter branch from e1caaaf to ce51be8 Compare December 19, 2021 16:00
@samsonasik samsonasik force-pushed the add-downgrade-reflection-class-get-constants-filter branch from 08dd5cd to 7117ee1 Compare December 19, 2021 16:48
@samsonasik
Copy link
Member Author

implemented 🎉

@samsonasik
Copy link
Member Author

I reverted temporary patch on #1474 that's use php 7.x compatible code to use php 8.0 code 82e7863, and try downgrade it:

bin/rector process src/DependencyInjection/Collector/ConfigureCallValuesCollector.php -c build/config/config-downgrade.php --dry-run

and it seems working ok 🎉

Screen Shot 2021-12-19 at 23 55 42

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 2a18c59 into main Dec 20, 2021
@TomasVotruba TomasVotruba deleted the add-downgrade-reflection-class-get-constants-filter branch December 20, 2021 11:58
@TomasVotruba
Copy link
Member

Thanks 👏 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Downgrade ReflectionClassConstant::IS_* on get constant name and value from ReflectionClass
3 participants
@samsonasik @TomasVotruba @actions-user