@TomasVotruba any other rule that handle it?

@TomasVotruba I think it is handy to update code like in CodeIgniter4 codeigniter4/CodeIgniter4#5462 that want to update private property only.

This rule was grouping 7 type infererrers together. It's too complex operation to hold them together, so they'll be split to 1 responsibility each in https://github.com/rectorphp/rector-src/tree/main/rules/TypeDeclaration/Rector/Property

• TypedPropertyFromStrictConstructorRector
• TypedPropertyFromStrictGetterMethodReturnTypeRector

The 2 doctrine ones will be moved to https://github.com/rectorphp/rector-doctrine

@TomasVotruba I think it is handy to update code like in CodeIgniter4 codeigniter4/CodeIgniter4#5462 that want to update private property only.

If possible, we should cover this behavior inside the rules itself, without having an option for it.
E.g. strict type should not be added to public property by Rector, as it's pure guessing.

If that needs to apply, then protected modifier should not be changed as well, as it can cause BC break with the following condition:

class A
{
    protected array $data = [];
}

class B extends A
{
    public function reset()
    {
        $this->data = null;
    }
}

(new B())->reset();

that will cause Fatal error:

Fatal error: Uncaught TypeError: Cannot assign null to property A::$data of type array in /in/EDR6K:12
Stack trace:
#0 /in/EDR6K(16): B->reset()

ref https://3v4l.org/EDR6K

If that needs to apply, then protected modifier should not be changed as well, as it can cause BC break with the following condition:

Yes, that is also dangerous 👍
I've updated test fixute to allow final class + protected property, and skip everything else.

@samsonasik Feel free to review & merge. I'm going out for a bit

Thank you @TomasVotruba