[NodeTypeResolver] Fix undefined method ReflectionProperty::getDefaultValue() on php 7.x #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tValue() on php 7.x
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
3 tasks
|
Thanks for the fix. We should have a downgrade Rector rule, that handles this. It's valid syntax on PHP 8.1. |
|
I will create separate PR for that, this PR is a temporary fix so we can have the fixed code early in the scoped version. |
|
Ok, let's merge temporary fix then. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rector got error :
When running on php 7.x
This PR try to fix it based on phpmanual comment https://www.php.net/manual/en/reflectionproperty.getdefaultvalue.php#126007
Note: New rector rule is needed for it.
Fixes rectorphp/rector#6869