Upgrade phpunit, switch CI, PHP8 Fix #188
Conversation
phpunit.xml
Outdated
| <!-- <whitelist addUncoveredFilesFromWhitelist="true">--> | ||
| <!-- <directory>./lib</directory>--> | ||
| <!-- </whitelist>--> | ||
| <!-- </filter>--> |
There was a problem hiding this comment.
This seems like a leftover, no?
Co-authored-by: Niklas Keller <me@kelunik.com>
|
I forgot this exists and did the changes manually. -.- |
Is it a fork of this repository ? Also, what about this repository. Is this now unmaintained ? In that case it would be better to archive this repository and used the one in amphp |
|
It is a fork, but removed linkage is probably mainly due to namespace changes and default PHP version requirements without having done a major version bump. Hopefully someone can get a note and link into the readme on this repo. IIRC, there is an issue or comment somewhere here about moving to amphp. |
|
The API changed quite a lot, yeah, we'll add links once there's a new release. |
|
Ah ok, thanks |
|
Feedback on the new API is highly appreciated! |
|
Thanks for the inspiration.....I eventually got around to upgrading things, but for reasons didn't accept the PR. Probably going to be doing a 2.0 release 'soon'. |
Upgraded phpunit, switch to github actions, fix for php 8. Take it or leave it.
I'll do another PR with just the php 8 fix.