Refactored Page, Navbar, and Template structure. #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor all forms to be just templates and refactor pages to be separate structs from templates. This allows us to add more fields to pages in the future without breaking existing page functions.
Apexal
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #218
This PR includes dynamic OGP tags. It also separates pages into their own struct, used instead of forms. Adding dynamic content to pages becomes easier with this change, as pages are now typed and additional fields can be as well.
This PR completely rewrites the navbar template to match OGP tags in the page template structure.
This PR also removes the specific structure dedicated to form templates and uses the normal template structure in its place.