Skip to content

fix: prevent duplicate submissions on user profile update #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2025
Merged

fix: prevent duplicate submissions on user profile update #1126

merged 2 commits into from
Sep 9, 2025

Conversation

rohilsurana
Copy link
Member

@rohilsurana rohilsurana commented Sep 9, 2025 •
edited
Loading

Summary

  • Added early return check in onSubmit to prevent duplicate form submissions
  • Synchronized submit logic with button disabled state (isLoading || isSubmitting)
  • Fixes duplicate success notifications when rapidly clicking submit button

Test Plan

  • Rapidly click the Update button on user profile form
  • Verify only one success notification appears
  • Verify only one API call is made
  • Test that button remains disabled during submission

@rohilsurana rohilsurana requested a review from rsbh September 9, 2025 09:23
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontier Ready Ready Preview Comment Sep 9, 2025 10:56am

@coveralls
Copy link

coveralls commented Sep 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17580332480

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.79%
Totals Coverage Status
Change from base Build 17573666038: 0.0%
Covered Lines: 10728
Relevant Lines: 33746
💛 - Coveralls

@rohilsurana rohilsurana force-pushed the feature/cld-2216-duplicate-success-notifications-after-multiple-submit-button branch from 3ab8db5 to 58587be Compare September 9, 2025 09:53
@rohilsurana rohilsurana force-pushed the feature/cld-2216-duplicate-success-notifications-after-multiple-submit-button branch from 58587be to a2caffb Compare September 9, 2025 09:56
@rohilsurana rohilsurana force-pushed the feature/cld-2216-duplicate-success-notifications-after-multiple-submit-button branch from a2caffb to 5e44989 Compare September 9, 2025 10:03
@rohilsurana rohilsurana force-pushed the feature/cld-2216-duplicate-success-notifications-after-multiple-submit-button branch from 5e44989 to d95f78a Compare September 9, 2025 10:23
@rohilsurana
fix(sdk): preserve in-progress edits on user data refresh
bf0ddd3 
Use reset(..., { keepDirtyValues: true }) so local form changes aren’t lost when user context updates, preventing unexpected button disable states.
@rohilsurana rohilsurana merged commit 808e2de into main Sep 9, 2025
7 checks passed
@rohilsurana rohilsurana deleted the feature/cld-2216-duplicate-success-notifications-after-multiple-submit-button branch September 9, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanchkrabrty rohanchkrabrty rohanchkrabrty approved these changes

@rsbh rsbh Awaiting requested review from rsbh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohilsurana @coveralls @rohanchkrabrty