feat: add CreateAuditRecord RPC
#1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 17573432177Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new CreateAuditRecord RPC endpoint that allows creating audit records with improved data structure compared to the legacy audit logs system. The implementation includes comprehensive validation, idempotency support, and database-level immutability constraints.
- Adds new
CreateAuditRecordRPC with comprehensive validation and idempotency - Implements new audit record data models with actor, resource, and target entities
- Adds database migration with immutability triggers to prevent record modifications
- Includes session management endpoints and deprecates legacy audit log endpoints
Reviewed Changes
Copilot reviewed 35 out of 37 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| proto files | Added new session and audit record message definitions, RPC endpoints, and validation |
| internal/store/postgres | Added audit record repository with immutability constraints and comprehensive tests |
| internal/api/v1beta1connect | Added service interface and error handling for audit records |
| pkg/metadata | Added utility function for safely building metadata from protobuf structs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
internal/store/postgres/migrations/20250904105226_add_audit_records_immutability.up.sql
Outdated
Show resolved
Hide resolved
rohilsurana
reviewed
Sep 8, 2025
rohilsurana
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.