Skip to content

MAC OS never detected #13

@TomVanWemmel

Description

@TomVanWemmel

I've been using mvn-jlink-wrapper on my machine with the following config

<provider>ADOPTIUM</provider>
<providerConfig>
    <repositoryName>temurin21-binaries</repositoryName>
    <version>21U</version>
    <arch>x64</arch>
    <type>jdk</type>
    <impl>hotspot</impl>
    <build>2024-01-14-11-20</build>
</providerConfig>

Unfortunately, on my Mac this fails unless I specifically put the <os>mac</os> configuration.
Instead the wrapper tries to download the unix binary.
This is caused by the following code:

public static HostOs findHostOs() {
  return VALUES.stream().filter(x -> x != UNKNOWN).filter(HostOs::isHostOs).findFirst()
      .orElse(UNKNOWN);
}

The resulting HostOs will be UNIX because org.apache.commons.lang3.SystemUtils.IS_OS_UNIX delegates to IS_OS_MAC_OSX.

Furthermore, even if it would detect the right OS, the id needs to be mac and not macos or macosx for the Adoptium provider.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions