-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Doc][KuberRay] add doc for kuberay with uv #53303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
|
||
This guide is the basic setting about how to build a custom image with uv as a package manager. For best practices, please reference https://github.com/astral-sh/uv-docker-example. | ||
|
||
The following example uses `kind` and `helm` to demostrate deploying to kubernetes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demostrate demonstrate :)
kind load docker-image ray-uv:demo | ||
``` | ||
|
||
Prepare RayCluster yaml file `ray-cluster.uv.yaml` with the following steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed guide, would be really awesome if we also add an example ray-cluster.uv.yaml
file. Or just a short example inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing it. I have added an example below.
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
@kevin85421 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to build an image?
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Discuss @kevin85421 move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the technical aspect. Still need the doc team's review.
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fscnick,
I pushed a commit to this branch: 5b1cc3b. Can you:
- verify whether the instructions work or not
- fix Vale issues if any
- move the file to https://docs.ray.io/en/latest/cluster/kubernetes/user-guides.html because
uv
integration is a Ray feature.
Thanks!
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Signed-off-by: fscnick <fscnick.dev@gmail.com>
Hi @kevin85421, I have verified the instructions except using nightly build, fixing vale and moving to user-guides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
.vale.ini
Outdated
@@ -19,3 +19,6 @@ Google.Colons = No | |||
# TODO(@bveeramani): We're temporarily disabling "Heading". In the future, we'll update | |||
# all headings and enable this rule. | |||
Google.Headings = No | |||
|
|||
# Ignore the (xxx-xxx...)= in a file because it is doc ref. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Ignore the (xxx-xxx...)= in a file because it is doc ref. | |
# Ignores the pattern `(xxx-xxx...)=` used as anchors for headers. |
Please confirm this is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fscnick Could you open an issue and a follow-up PR for the change to .vale.ini
? We can remove the change from this PR.
It's OK if (kuberay-uv)=
doesn't follow Vale rules—this usage appears throughout the entire codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened. #53516
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
Co-authored-by: Douglas Strodtman <douglas@anyscale.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
cc @pcmoritz Just a heads-up: we’ll start promoting uv starting with KubeRay v1.4.0, which is coming out soon. |
@dstrodtman would you mind approving this PR if it looks good to you? Thanks! |
# ['Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍', 'Python is 👍'] | ||
``` | ||
|
||
> NOTE: Use `/bin/bash -c` to execute the command while changing the current directory to `/home/ray/samples`. The default `working_dir` would be the current directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming: this instruction and description are to let the user set the working_dir to /home/ray/samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org>
@dstrodtman thank you for the quick review! |
``` | ||
|
||
The `ray-cluster.uv.yaml` YAML file contains a RayCluster custom resource and a ConfigMap that includes a sample Ray Python script. | ||
* The `RAY_RUNTIME_ENV_HOOK` feature flag enables the `uv` integration in Ray. Future versions may enable this by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's right, the PR for this has actually already been merged #53060, will be released with Ray 2.47 :)
Obviously we need to leave this in the docs right now, but after Ray 2.47 is released let's add a note that this is not needed any more in Ray >= 2.47.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open an issue to track the progress: ray-project/kuberay#3732
Why are these changes needed?
To provide the guide for the user who wants to use
uv
with kuberay.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.