Skip to content

[Core] Add bundle_label_selector scheduling logic #52988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 30, 2025
Merged

[Core] Add bundle_label_selector scheduling logic #52988

merged 12 commits into from
May 30, 2025

Conversation

ryanaoleary
Copy link
Contributor

Why are these changes needed?

This PR adds the bundle_label_selector option to Ray PlacementGroups, applying the label selectors on a per-bundle level to define label constraints for scheduling bundles on a node.

This PR passes the bundle_label_selector from the PlacementGroup options to the Raylet where the PlacementGroupSpec is built. Inside PlacementGroupSpec, each label selector is added to its corresponding Bundle message, and then added to the ResourceRequest in ComputeResources when the BundleSpec is constructed. This enables the cluster resource scheduler to check for required labels when calling IsFeasible and IsAvailable on a Node.

Related issue number

#51564

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ryanaoleary
Add bundle_label_selector scheduling logic initial commit
a726854 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary ryanaoleary mentioned this pull request May 14, 2025
Open
23 tasks
@ryanaoleary
Merge branch 'master' into add-bundle-selector-api
90fc136 
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
@ryanaoleary ryanaoleary self-assigned this May 14, 2025
@ryanaoleary ryanaoleary requested review from MengjinYan and edoakes May 14, 2025 03:53
ryanaoleary and others added 3 commits May 14, 2025 04:10
@ryanaoleary
Fix BUILD for test
f1b8832 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary
Add default bundle_label_selector to PlacementGroupCreationOptions
029dfdd 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary
Merge branch 'master' into add-bundle-selector-api
fc65425
@ryanaoleary ryanaoleary marked this pull request as ready for review May 14, 2025 23:33
@ryanaoleary ryanaoleary requested review from pcmoritz, raulchen and a team as code owners May 14, 2025 23:33
@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label May 15, 2025
@masoudcharkhabi masoudcharkhabi added docs An issue or change related to documentation core Issues that should be addressed in Ray Core labels May 15, 2025
MengjinYan
MengjinYan reviewed May 23, 2025
View reviewed changes
Copy link
Collaborator

@MengjinYan MengjinYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MengjinYan
Copy link
Collaborator

@dayshah or @israbbani Do you mind take a brief look from c++'s perspective to see if there is any c++ particular comments? Thanks!

dayshah
dayshah approved these changes May 25, 2025
View reviewed changes
Copy link
Contributor

@dayshah dayshah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor cpp nit, otherwise lgtm from cpp perspective. +1 on @MengjinYan comments

ryanaoleary and others added 2 commits May 27, 2025 13:34
@ryanaoleary @dayshah
Update src/ray/common/bundle_spec.cc
e35842d 
Co-authored-by: Dhyey Shah <dhyey2019@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
@ryanaoleary
Fix comments and library test failures
dc463ba 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary ryanaoleary requested a review from MengjinYan May 28, 2025 06:11
dayshah
dayshah reviewed May 28, 2025
View reviewed changes
ryanaoleary and others added 2 commits May 27, 2025 23:17
@ryanaoleary @dayshah
Update src/ray/common/scheduling/cluster_resource_data.h
03267ae 
Co-authored-by: Dhyey Shah <dhyey2019@gmail.com>
Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
@ryanaoleary
Remove unnecessary field and make arg default
b09cd97 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@MengjinYan MengjinYan added the go add ONLY when ready to merge, run all tests label May 29, 2025
@edoakes edoakes merged commit ec24551 into ray-project:master May 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dayshah dayshah dayshah approved these changes

@MengjinYan MengjinYan MengjinYan approved these changes

@edoakes edoakes Awaiting requested review from edoakes

@pcmoritz pcmoritz Awaiting requested review from pcmoritz

@raulchen raulchen Awaiting requested review from raulchen

Assignees

@MengjinYan MengjinYan

@ryanaoleary ryanaoleary

Labels
community-contribution Contributed by the community core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ryanaoleary @MengjinYan @dayshah @masoudcharkhabi @edoakes @hainesmichaelc