Skip to content

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Apr 7, 2025

This reverts commit 0a5f970.

Why are these changes needed?

This is a breaking change and beaks release test.

2025-04-06 23:31:38,300	PANIC scripts.py:748 -- `--labels={"anyscale.com/availability_zone":"us-west-2a"}` is not a valid string of key-value pairs, detail error:Label value is not a key-value pair.Valid values look like this: `--labels="key1=val1,key2=val2"`
Error: `{}` is not a valid string of key-value pairs, detail error:{}Valid values look like this: `{}`

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Apr 7, 2025
@jjyao jjyao merged commit 78959be into ray-project:master Apr 7, 2025
2 of 5 checks passed
@jjyao jjyao deleted the jjyao/revvert branch April 7, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-backlog go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants