Skip to content

[Autoscaler] Add bundle_label_selector to request_resources sdk #54843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Autoscaler] Add bundle_label_selector to request_resources sdk #54843

wants to merge 4 commits into from

Conversation

ryanaoleary
Copy link
Contributor

@ryanaoleary ryanaoleary commented Jul 22, 2025 •
edited
Loading

Why are these changes needed?

This change adds a bundle_label_selector argument to the request_resources sdk command for the v2 Ray autoscaler. This command is used by several Ray libraries. The bundle_label_selector is a parallel list to the bundles of resource shapes specified by the user and are applied per-bundle. These label selectors are passed to the repeated LabelSelector label_selectors field in the ResourceRequest message that gets built by RequestClusterResourceConstraint.

This change depends on #53578.

Related issue number

Contributes to #51564

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ryanaoleary ryanaoleary requested a review from a team as a code owner July 22, 2025 22:30
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ryanaoleary
Copy link
Contributor Author

cc: @MengjinYan

@ray-gardener ray-gardener bot added community-contribution Contributed by the community docs An issue or change related to documentation core Issues that should be addressed in Ray Core labels Jul 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 7, 2025
@ryanaoleary ryanaoleary mentioned this pull request Aug 7, 2025
Open
23 tasks
@edoakes
Copy link
Collaborator

edoakes commented Aug 7, 2025

Tons of merge conflicts @ryanaoleary

@github-actions github-actions bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Aug 8, 2025
@ryanaoleary ryanaoleary force-pushed the request-resources-labels branch 2 times, most recently from b031c33 to 83d8bcc Compare August 11, 2025 14:30
@ryanaoleary
Add tests for fallback and scoring, and add label selector hashing
2ca6049 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary
Add label_selectors to request_resources bundles
f2eab50 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary
Fix test
a0199b0 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary ryanaoleary force-pushed the request-resources-labels branch from 83d8bcc to a0199b0 Compare August 11, 2025 14:36
@ryanaoleary
Fix rebase
53cdae0 
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
@ryanaoleary
Copy link
Contributor Author

Rebased and re-tested, should all be fixed now cc: @edoakes @MengjinYan

@edoakes
Copy link
Collaborator

edoakes commented Aug 15, 2025

ping @MengjinYan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution Contributed by the community core Issues that should be addressed in Ray Core docs An issue or change related to documentation unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanaoleary @edoakes