[Build][kubectl-plugin] Add release script for kubectl plugin #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: ray-project#2406 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
|
@chiayi PTAL |
kevin85421
approved these changes
Sep 28, 2024
Closes: ray-project#2406 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
andrewsykim
approved these changes
Sep 28, 2024
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # TODO(MortalHappiness): This won't work now. The first version of plugin has to be submitted manually by use to the krew-index repo, so I'll submit a PR to the krew-index repo once a release candidate is created. | ||
| - name: Update new version in krew-index | ||
| uses: rajatjindal/krew-release-bot@v0.0.46 |
There was a problem hiding this comment.
Is this the standard project used with krew to publish plugin?
There was a problem hiding this comment.
It's mentioned in the official doc and says strongly recommends
https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See the description in the corresponding issue for details.
This PR will build the kubectl plugin with goreleaser and upload them to GitHub release whenever a semver tag is created.
See the example auto-generated GitHub release here:
https://github.com/MortalHappiness/kuberay/releases/tag/v1.3.0-rc.0
The first version of plugin has to be submitted manually by us to the krew-index repo, so I'll submit a PR to the krew-index repo once a release candidate is created.
Related issue number
Closes: #2406
Checks