Skip to content

[Feat][Kubectl-Plugin]Implement kubectl ray job submit #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Sep 21, 2024

Why are these changes needed?

This PR implements the kubectl ray submit job command.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chiayi chiayi force-pushed the kubectl-plugin branch 6 times, most recently from 750f91a to bfce6bb Compare September 24, 2024 01:40
@chiayi
Copy link
Contributor Author

chiayi commented Sep 24, 2024

I had a video of successful run but the file is bigger than 10MB, so resorting to screenshots:

Terminal:
Screenshot 2024-09-24 at 3 42 40 PM

Ray Operator:
When the job is submitted:
Screenshot 2024-09-24 at 3 43 43 PM

Once it found the ray submit job.
Screenshot 2024-09-24 at 3 44 13 PM

@chiayi
Copy link
Contributor Author

chiayi commented Sep 24, 2024

Few things to note currently:

  1. Code that is inputted into [Entrypont] isn't pased correctly. When running with entrypoint: python -c "import ray; ray.init(); print(ray.cluster_resources())" the args gets parsed by cobra command and/or os and it becomes different arguments split by the space and the quotes removed.
Screenshot 2024-09-24 at 3 48 29 PM Removing space between the code also seem to have the same effect.
  1. For some reason the runtime env set in rayjob.yaml CR isn't used. I had to create new file for runtime_env for it to be recognized. Not sure if this is expected behavior.
Screenshot 2024-09-24 at 3 55 05 PM
  1. There are still unimplemented ray submit commands like --runtime-env-json, --verify, and --header

@chiayi chiayi force-pushed the kubectl-plugin branch 3 times, most recently from 57f5a6c to 076a1a3 Compare September 24, 2024 23:44
@chiayi chiayi force-pushed the kubectl-plugin branch 5 times, most recently from bb32d04 to e2e3af8 Compare September 26, 2024 03:28
@chiayi chiayi force-pushed the kubectl-plugin branch 7 times, most recently from e5aa2c9 to 45d3729 Compare September 26, 2024 21:32
@chiayi chiayi marked this pull request as ready for review September 26, 2024 21:32
@chiayi
Copy link
Contributor Author

chiayi commented Sep 26, 2024

Latest Runs:
with working dir within runtime env file
Screenshot 2024-09-26 at 3 52 34 PM

working dir is explicit
Screenshot 2024-09-26 at 3 55 14 PM

Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your great work!

cc @andrewsykim @kevin85421

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge the PR after CI passes, and I will start to prepare a minor release for Ray Summit.

@kevin85421 kevin85421 merged commit 6786350 into ray-project:master Sep 27, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants