-
Notifications
You must be signed in to change notification settings - Fork 603
[Feat][Kubectl-Plugin]Implement kubectl ray job submit #2394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Sep 21, 2024
750f91a
to
bfce6bb
Compare
MortalHappiness
requested changes
Sep 24, 2024
bfce6bb
to
e78f3a6
Compare
andrewsykim
reviewed
Sep 24, 2024
57f5a6c
to
076a1a3
Compare
MortalHappiness
requested changes
Sep 25, 2024
bb32d04
to
e2e3af8
Compare
MortalHappiness
requested changes
Sep 26, 2024
e5aa2c9
to
45d3729
Compare
MortalHappiness
requested changes
Sep 27, 2024
45d3729
to
cd3d7b3
Compare
MortalHappiness
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your great work!
kevin85421
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge the PR after CI passes, and I will start to prepare a minor release for Ray Summit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements the
kubectl ray submit job
command.Related issue number
Checks