[Feature][RayCluster]: Generate GCS FT Redis Cleanup Job creation events #2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rueian <rueiancsie@gmail.com>
|
Hi @kevin85421, please take a look. Thanks! |
kevin85421
approved these changes
Sep 16, 2024
| @@ -302,9 +302,13 @@ func (r *RayClusterReconciler) rayClusterReconcile(ctx context.Context, request | |||
| logger.Info("Redis cleanup Job already exists. Requeue the RayCluster CR.") | |||
| return ctrl.Result{RequeueAfter: DefaultRequeueDuration}, nil | |||
| } | |||
| r.Recorder.Eventf(instance, corev1.EventTypeWarning, string(utils.FailedToCreateRedisCleanupJob), | |||
| "Failed to create Redis cleanup Job %s/%s, %v", redisCleanupJob.Namespace, redisCleanupJob.Name, err) | |||
There was a problem hiding this comment.
nit: make the wording consistent. Either "Failed to create" or "Failed creating" is fine.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Following the KubeRay CRD Observability Improvement Workstream, we add the two missing events for Redis Cleanup Job Creation:
Related issue number
Checks