[Test][RayCluster] Add envtests for RayCluster conditions #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
669bd96 to
587af6f
Compare
kevin85421
reviewed
Aug 3, 2024
| } | ||
| return meta.IsStatusConditionPresentAndEqual(rayCluster.Status.Conditions, string(rayv1.RayClusterReady), metav1.ConditionTrue) | ||
| }, | ||
| time.Second*3, time.Millisecond*500).Should(BeTrue()) |
There was a problem hiding this comment.
Can you check the following cases:
- Update a worker pod to become unready; the
RayClusterReadystatus should still be true. - Update the head pod to become unready; the
RayClusterReadystatus should be false.
e3824a2 to
a0d6a44
Compare
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
a0d6a44 to
d839e33
Compare
kevin85421
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, RayCluster conditions only have unit tests. This PR adds envtests for RayCluster conditions.
Note that this PR needs #2282 to work properly, otherwise the tests will fail.
Related issue number
N/A
Checks