Don’t assign the rayv1.Failed to the State field #2258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b9f64c to
e1ab54e
Compare
e1ab54e to
8bf92ea
Compare
kevin85421
reviewed
Jul 19, 2024
There was a problem hiding this comment.
-
The feature gate is only used to determine whether to write to the new
conditionsfield. For this PR, we only need to avoid assigningrayv1.Failedto.Status.State. -
Add a comment to Failed indicating that it is deprecated, but we keep it to avoid compilation errors in projects that import the KubeRay Golang module.
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
9c28ce9 to
255c07d
Compare
kevin85421
approved these changes
Jul 19, 2024
Closed
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We should always stop writing
rayv1.Failedto theStatus.Statefield. The detailed reason is described here:https://docs.google.com/document/d/1bRL0cZa87eCX6SI7gqthN68CgmHaB6l3-vJuIse-BrY/edit . The new way to indicate failure is described here: https://github.com/ray-project/kuberay/pull/2245/filesRelated issue number
Closes #2234
Checks