Skip to content

Add kubectl plugin with basic command #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add kubectl plugin with basic command #2243

merged 1 commit into from
Jul 17, 2024

Conversation

chiayi
Copy link
Contributor

@chiayi chiayi commented Jul 12, 2024 •
edited
Loading

Why are these changes needed?

Deprecating old CLI and adding ray kubectl plugin

Discussed with @kevin85421 to delete cli/.

Related issue number

Instructions for installation

  1. Navigate to kubectl-plugin/
  2. Run go build cmd/kubectl-ray.go
  3. Run sudo cp ./kubectl-ray /usr/local/bin
  4. Ensure that you have kuberay-operator and a kuberay cluster
  5. Run kubectl ray cluster get
Screenshot 2024-07-17 at 11 33 48 AM

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chiayi chiayi closed this Jul 12, 2024
@chiayi chiayi reopened this Jul 12, 2024
@chiayi chiayi marked this pull request as draft July 12, 2024 20:39
kevin85421
kevin85421 reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about separating the deprecation and the new Kubectl plugin PR into two separate PRs?

@kevin85421 kevin85421 self-assigned this Jul 12, 2024
@chiayi chiayi force-pushed the kubectl-plugin branch 2 times, most recently from 39ca12a to 68b7692 Compare July 15, 2024 17:44
@chiayi chiayi mentioned this pull request Jul 15, 2024
Merged
4 tasks
@chiayi chiayi changed the title Add kubectl plugin with basic command and deprecate cli Add kubectl plugin with basic command Jul 15, 2024
@chiayi chiayi force-pushed the kubectl-plugin branch 2 times, most recently from ce3d790 to 987b0e5 Compare July 16, 2024 18:34
@chiayi chiayi marked this pull request as ready for review July 16, 2024 19:00
kevin85421
kevin85421 reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind:

(1) adding some comments to the code
(2) run the pre-commit locally https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#pre-commit-hooks and add the lint checks in CI in the follow up PR
(3) add the instructions in the PR description and add a screenshot

Thanks!

@chiayi
Copy link
Contributor Author

chiayi commented Jul 17, 2024 •
edited
Loading

@kevin85421 Added screenshots and instructions for installations on the PR description. PTAL! Thanks!

@chiayi
Copy link
Contributor Author

chiayi commented Jul 17, 2024 •
edited
Loading

Oh I just realized that the age that kubectl get raycluster has is different from kubectl ray cluster get off by around 10 seconds. Looking into it. I think its just the time between when I called the two cmds.

@kevin85421
Copy link
Member

The flaky test still fails, but I think it has no relationship with this PR. Merge this PR.

@kevin85421 kevin85421 merged commit abafd17 into ray-project:master Jul 17, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiayi @kevin85421