Skip to content

Allow configuration of restartPolicy #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

Allow configuration of restartPolicy #2197

merged 1 commit into from
Jun 20, 2024

Conversation

c0dearm
Copy link
Contributor

@c0dearm c0dearm commented Jun 18, 2024 •
edited
Loading

Why are these changes needed?

For a correct configuration of the v2 autoscaler, it is necessary to override the restartPolicy. See: https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/configuring-autoscaling.html#autoscaler-v2-with-kuberay

Related issue number

No issue

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@c0dearm c0dearm changed the title Master Allow configuration of restartPolicy Jun 18, 2024
@kevin85421 kevin85421 self-assigned this Jun 20, 2024
kevin85421
kevin85421 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kevin85421 kevin85421 merged commit 828afba into ray-project:master Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0dearm @kevin85421