Skip to content

[Style] Fix golangci-lint rule: ginkgolinter #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

Based on #2128, there are some rules that need manual fixing. This PR fixes the rule: ginkgolinter

See https://golangci-lint.run/usage/linters/ for details.

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness marked this pull request as draft May 30, 2024 09:51
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/golangci-lint-ginkgolinter branch from 64a9ffa to 83ea39e Compare May 30, 2024 10:49
@MortalHappiness MortalHappiness marked this pull request as ready for review May 30, 2024 10:49
@kevin85421 kevin85421 self-assigned this May 30, 2024
@kevin85421 kevin85421 merged commit 6b932b5 into ray-project:master Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants