Skip to content

[Chore] Use new golangci-lint rules only for ray-operator #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented May 16, 2024

Why are these changes needed?

Some CI fails because other modules (e.g. experimental) also use golangci-lint and the new rules in the repository root cause them to fail.

Therefore, this PR moves the .golangci.yml into the ray-operator folder.

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@kevin85421 kevin85421 merged commit 949875a into ray-project:master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants