[Style] Fix golangci-lint rule: noctx #2142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
7bebb21 to
0fc782a
Compare
kevin85421
approved these changes
May 15, 2024
| @@ -50,7 +50,11 @@ func (r *RayHttpProxyClient) SetHostIp(hostIp, podNamespace, podName string, por | |||
|
|
|||
| // CheckProxyActorHealth checks the health status of the Ray Serve proxy actor. | |||
| func (r *RayHttpProxyClient) CheckProxyActorHealth(ctx context.Context) error { | |||
| resp, err := r.client.Get(r.httpProxyURL + RayServeProxyHealthPath) | |||
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, r.httpProxyURL+RayServeProxyHealthPath, nil) | |||
There was a problem hiding this comment.
Note: "You should use noctx if sending http request in your library. Passing context.Context enables library user to cancel http request, getting trace information and so on."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Based on #2128, there are some rules that need manual fixing. This PR fixes the rule:
noctxSee https://golangci-lint.run/usage/linters/ for details.
Related issue number
N/A
Checks