Skip to content

[Chore] Delete redundant pod existance checking #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

The names of the head and worker pods are generated, so the names are different every time. It is useless to check whether the previous pods are still terminating because we cannot even know their names based on the current names.

podTemplate.GenerateName = podName

podTemplate.GenerateName = podName

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@kevin85421 kevin85421 self-requested a review May 3, 2024 00:29
@kevin85421 kevin85421 self-assigned this May 3, 2024
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevin85421 kevin85421 merged commit e0318a3 into ray-project:master May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants