Skip to content

[Chore][Samples] Rename ray-cluster.mini.yaml and add workerGroupSpecs #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

There are ray-job.sample.yaml and ray-service.sample.yaml but no ray-cluster.sample.yaml. Also it seems that ray-cluster.mini.yaml is not useful because it does not specify workerGroupSpecs. Therefore, this PR:

  1. Rename ray-cluster.mini.yaml to ray-cluster.sample.yaml.
  2. Add workerGroupSpecs section in that file.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421 kevin85421 self-assigned this Apr 25, 2024
@kevin85421 kevin85421 self-requested a review April 25, 2024 22:52
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/update-raycluster-sample branch from 36fc7b5 to e0f50e4 Compare May 1, 2024 09:07
@kevin85421 kevin85421 merged commit 296d480 into ray-project:master May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants