Skip to content

[Sample][autoscaler v2] Add sample yaml for autosclaer v2 #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 30, 2024

Conversation

rickyyx
Copy link
Member

@rickyyx rickyyx commented Mar 8, 2024

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx
Copy link
Member Author

rickyyx commented Mar 8, 2024

Oh is it because ray hasn't released yet: https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/3454#018e1b6f-1a44-455d-95f2-13c63684d786 ?

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx
Copy link
Member Author

rickyyx commented Mar 8, 2024

I see - so using nightly works. Maybe I will update this to be 2.10.0 once ray releases.

@rickyyx rickyyx marked this pull request as draft March 8, 2024 01:59
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx marked this pull request as ready for review March 23, 2024 17:20
@rickyyx
Copy link
Member Author

rickyyx commented Mar 23, 2024

Update with 2.10.0.

@kevin85421
Copy link
Member

Would you mind rebasing with the master branch? Thanks!

@rickyyx
Copy link
Member Author

rickyyx commented Mar 27, 2024

ping for review @kevin85421

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this PR. I will update the YAML in a follow up PR.

@kevin85421 kevin85421 merged commit 9b8d34c into master Mar 30, 2024
@kevin85421 kevin85421 deleted the rickyx/pr-auto-v2 branch January 21, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants