Add easy musl #301
Merged
Add easy musl #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add openssl's features for musl
|
Not sure it's the right thing to do. Vendored openssl has various drawbacks e.g. it can't respect the system root certificate, and it doesn't get updated so it's not as secure. Also I wonder if this impact binary size |
|
My system is Rocky8, and the Glib version is 2.28, which is very inconvenient to upgrade. Although the size of the binary file has been increased, I believe it is well worth it |
|
In that case, can you try only vendor openssl for musl release? |
musl
|
You're right. I've made the modifications, enabling vendor dependencies exclusively for musl compilation. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added dependencies to Cargo, ensuring that OpenSSL is correctly included with features during the compilation of musl, eliminating the need to separately handle OpenSSL for musl. We still find musl necessary because handling dependencies can be quite challenging.
#300