Skip to content

chore(ci): update release strategy #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2024
Merged

chore(ci): update release strategy #1337

merged 3 commits into from
Aug 25, 2024

Conversation

orhun
Copy link
Member

@orhun orhun commented Aug 22, 2024

closes #1232

Now we can trigger point releases by pushing a tag (follow the instructions in RELEASE.md). This will create a release with generated changelog.

There is still a lack of automation (e.g. updating CHANGELOG.md), but this PR is a good start towards improving that.

@orhun orhun requested a review from a team as a code owner August 22, 2024 16:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

🐰Bencher

ReportSun, August 25, 2024 at 08:17:52 UTC
ProjectRatatui
Branch1337/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
barchart/render/2048➖ (view plot)207,610.00
barchart/render/256➖ (view plot)139,490.00
barchart/render/64➖ (view plot)90,929.00
barchart/render_grouped/2048➖ (view plot)353,500.00
barchart/render_grouped/256➖ (view plot)150,760.00
barchart/render_grouped/64➖ (view plot)138,780.00
barchart/render_horizontal/2048➖ (view plot)161,330.00
barchart/render_horizontal/256➖ (view plot)79,937.00
barchart/render_horizontal/64➖ (view plot)74,161.00
block/render_all_feature/100x50➖ (view plot)9,945.70
block/render_all_feature/200x50➖ (view plot)17,818.00
block/render_all_feature/256x256➖ (view plot)83,591.00
block/render_empty/100x50➖ (view plot)5,489.50
block/render_empty/200x50➖ (view plot)10,912.00
block/render_empty/256x256➖ (view plot)70,394.00
buffer/empty/16➖ (view plot)777.89
buffer/empty/255➖ (view plot)226,770.00
buffer/empty/64➖ (view plot)13,416.00
buffer/filled/16➖ (view plot)772.06
buffer/filled/255➖ (view plot)217,800.00
buffer/filled/64➖ (view plot)13,059.00
buffer/with_lines/16➖ (view plot)9,551.00
buffer/with_lines/255➖ (view plot)8,507.90
buffer/with_lines/64➖ (view plot)8,713.10
line_render/Center/0➖ (view plot)4.02
line_render/Center/10➖ (view plot)434.13
line_render/Center/3➖ (view plot)234.81
line_render/Center/4➖ (view plot)258.93
line_render/Center/42➖ (view plot)552.26
line_render/Center/6➖ (view plot)270.69
line_render/Center/7➖ (view plot)304.40
line_render/Left/0➖ (view plot)4.02
line_render/Left/10➖ (view plot)388.08
line_render/Left/3➖ (view plot)155.50
line_render/Left/4➖ (view plot)167.74
line_render/Left/42➖ (view plot)552.69
line_render/Left/6➖ (view plot)258.11
line_render/Left/7➖ (view plot)272.23
line_render/Right/0➖ (view plot)4.02
line_render/Right/10➖ (view plot)396.94
line_render/Right/3➖ (view plot)221.59
line_render/Right/4➖ (view plot)261.35
line_render/Right/42➖ (view plot)552.07
line_render/Right/6➖ (view plot)336.74
line_render/Right/7➖ (view plot)377.58
list/render/16384➖ (view plot)1,145,500.00
list/render/2048➖ (view plot)261,180.00
list/render/64➖ (view plot)140,200.00
list/render_scroll_half/16384➖ (view plot)1,156,000.00
list/render_scroll_half/2048➖ (view plot)267,410.00
list/render_scroll_half/64➖ (view plot)95,953.00
paragraph/new/2048➖ (view plot)250,410.00
paragraph/new/64➖ (view plot)6,638.00
paragraph/new/65535➖ (view plot)8,235,900.00
paragraph/render/2048➖ (view plot)439,510.00
paragraph/render/64➖ (view plot)402,950.00
paragraph/render/65535➖ (view plot)1,549,300.00
paragraph/render_scroll_full/2048➖ (view plot)399,100.00
paragraph/render_scroll_full/64➖ (view plot)421,940.00
paragraph/render_scroll_full/65535➖ (view plot)1,494,100.00
paragraph/render_scroll_half/2048➖ (view plot)398,370.00
paragraph/render_scroll_half/64➖ (view plot)427,710.00
paragraph/render_scroll_half/65535➖ (view plot)1,507,200.00
paragraph/render_wrap/2048➖ (view plot)226,930.00
paragraph/render_wrap/64➖ (view plot)186,100.00
paragraph/render_wrap/65535➖ (view plot)1,422,000.00
paragraph/render_wrap_scroll_full/2048➖ (view plot)228,620.00
paragraph/render_wrap_scroll_full/64➖ (view plot)186,610.00
paragraph/render_wrap_scroll_full/65535➖ (view plot)1,412,400.00
rect_rows/rows/1024➖ (view plot)326.67
rect_rows/rows/16➖ (view plot)5.25
rect_rows/rows/65535➖ (view plot)20,306.00
sparkline/render/2048➖ (view plot)121,850.00
sparkline/render/256➖ (view plot)120,220.00
sparkline/render/64➖ (view plot)38,135.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

joshka
joshka reviewed Aug 22, 2024
View reviewed changes
joshka
joshka approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nits

@orhun orhun merged commit 65da535 into ratatui:main Aug 25, 2024
37 checks passed
@orhun orhun deleted the chore/update_release_docs branch August 25, 2024 08:02
@codecov Codecov
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (0d5f3c0) to head (e45f51d).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #1337    +/-   ##
======================================
  Coverage   94.1%   94.1%            
======================================
  Files         67      67            
  Lines      15627   15825   +198     
======================================
+ Hits       14712   14905   +193     
- Misses       915     920     +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun mentioned this pull request Aug 25, 2024
Merged
orhun added a commit that referenced this pull request Aug 25, 2024
@orhun
chore(release): prepare for 0.28.1 (#1343)
3a90e2a 
🧀 

The current release steps in reference to #1337

- Bump version in `Cargo.toml`
- `git cliff -u -p CHANGELOG.md -t v0.28.1`
- Merge the PR
- `git tag v0.28.1`
- `git push origin v0.28.1`

We can probably automate away most of these with `release-plz` when it
fully supports `git-cliff`'s GitHub integration.
joshka pushed a commit to erak/ratatui that referenced this pull request Oct 14, 2024
@orhun @joshka
chore(ci): update release strategy (ratatui#1337)
3ea0af0 
closes ratatui#1232 

Now we can trigger point releases by pushing a tag (follow the
instructions in `RELEASE.md`). This will create a release with generated
changelog.

There is still a lack of automation (e.g. updating `CHANGELOG.md`), but
this PR is a good start towards improving that.
joshka pushed a commit to erak/ratatui that referenced this pull request Oct 14, 2024
@orhun @joshka
chore(release): prepare for 0.28.1 (ratatui#1343)
cb16eb5 
🧀 

The current release steps in reference to ratatui#1337

- Bump version in `Cargo.toml`
- `git cliff -u -p CHANGELOG.md -t v0.28.1`
- Merge the PR
- `git tag v0.28.1`
- `git push origin v0.28.1`

We can probably automate away most of these with `release-plz` when it
fully supports `git-cliff`'s GitHub integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rapid Releases
2 participants
@orhun @joshka