fix: remove trailing newline from single-line Text::Display #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
=======================================
- Coverage 94.3% 94.3% -0.1%
=======================================
Files 65 65
Lines 15565 15561 -4
=======================================
- Hits 14689 14685 -4
Misses 876 876 ☔ View full report in Codecov by Sentry. |
|
| Report | Sun, August 11, 2024 at 15:17:49 UTC |
| Project | Ratatui |
| Branch | 1320/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| barchart/render/2048 | ➖ (view plot) | 191,820.00 |
| barchart/render/256 | ➖ (view plot) | 126,070.00 |
| barchart/render/64 | ➖ (view plot) | 79,685.00 |
| barchart/render_grouped/2048 | ➖ (view plot) | 342,240.00 |
| barchart/render_grouped/256 | ➖ (view plot) | 134,300.00 |
| barchart/render_grouped/64 | ➖ (view plot) | 122,010.00 |
| barchart/render_horizontal/2048 | ➖ (view plot) | 163,240.00 |
| barchart/render_horizontal/256 | ➖ (view plot) | 82,863.00 |
| barchart/render_horizontal/64 | ➖ (view plot) | 74,039.00 |
| block/render_all_feature/100x50 | ➖ (view plot) | 10,249.00 |
| block/render_all_feature/200x50 | ➖ (view plot) | 18,099.00 |
| block/render_all_feature/256x256 | ➖ (view plot) | 85,172.00 |
| block/render_empty/100x50 | ➖ (view plot) | 5,701.30 |
| block/render_empty/200x50 | ➖ (view plot) | 11,180.00 |
| block/render_empty/256x256 | ➖ (view plot) | 71,554.00 |
| buffer/empty/16 | ➖ (view plot) | 778.96 |
| buffer/empty/255 | ➖ (view plot) | 226,350.00 |
| buffer/empty/64 | ➖ (view plot) | 13,078.00 |
| buffer/filled/16 | ➖ (view plot) | 776.64 |
| buffer/filled/255 | ➖ (view plot) | 229,930.00 |
| buffer/filled/64 | ➖ (view plot) | 13,318.00 |
| buffer/with_lines/16 | ➖ (view plot) | 8,600.10 |
| buffer/with_lines/255 | ➖ (view plot) | 8,643.50 |
| buffer/with_lines/64 | ➖ (view plot) | 8,953.10 |
| line_render/Center/0 | ➖ (view plot) | 3.72 |
| line_render/Center/10 | ➖ (view plot) | 438.14 |
| line_render/Center/3 | ➖ (view plot) | 243.50 |
| line_render/Center/4 | ➖ (view plot) | 270.25 |
| line_render/Center/42 | ➖ (view plot) | 556.74 |
| line_render/Center/6 | ➖ (view plot) | 280.01 |
| line_render/Center/7 | ➖ (view plot) | 308.94 |
| line_render/Left/0 | ➖ (view plot) | 3.71 |
| line_render/Left/10 | ➖ (view plot) | 399.71 |
| line_render/Left/3 | ➖ (view plot) | 155.68 |
| line_render/Left/4 | ➖ (view plot) | 171.96 |
| line_render/Left/42 | ➖ (view plot) | 556.54 |
| line_render/Left/6 | ➖ (view plot) | 264.54 |
| line_render/Left/7 | ➖ (view plot) | 276.43 |
| line_render/Right/0 | ➖ (view plot) | 3.71 |
| line_render/Right/10 | ➖ (view plot) | 405.31 |
| line_render/Right/3 | ➖ (view plot) | 231.40 |
| line_render/Right/4 | ➖ (view plot) | 268.87 |
| line_render/Right/42 | ➖ (view plot) | 559.78 |
| line_render/Right/6 | ➖ (view plot) | 347.12 |
| line_render/Right/7 | ➖ (view plot) | 389.84 |
| list/render/16384 | ➖ (view plot) | 1,159,700.00 |
| list/render/2048 | ➖ (view plot) | 262,010.00 |
| list/render/64 | ➖ (view plot) | 145,080.00 |
| list/render_scroll_half/16384 | ➖ (view plot) | 1,152,100.00 |
| list/render_scroll_half/2048 | ➖ (view plot) | 269,080.00 |
| list/render_scroll_half/64 | ➖ (view plot) | 99,718.00 |
| paragraph/new/2048 | ➖ (view plot) | 252,290.00 |
| paragraph/new/64 | ➖ (view plot) | 6,639.60 |
| paragraph/new/65535 | ➖ (view plot) | 8,057,600.00 |
| paragraph/render/2048 | ➖ (view plot) | 441,660.00 |
| paragraph/render/64 | ➖ (view plot) | 401,690.00 |
| paragraph/render/65535 | ➖ (view plot) | 1,514,200.00 |
| paragraph/render_scroll_full/2048 | ➖ (view plot) | 387,320.00 |
| paragraph/render_scroll_full/64 | ➖ (view plot) | 418,730.00 |
| paragraph/render_scroll_full/65535 | ➖ (view plot) | 1,478,900.00 |
| paragraph/render_scroll_half/2048 | ➖ (view plot) | 389,880.00 |
| paragraph/render_scroll_half/64 | ➖ (view plot) | 428,200.00 |
| paragraph/render_scroll_half/65535 | ➖ (view plot) | 1,470,300.00 |
| paragraph/render_wrap/2048 | ➖ (view plot) | 220,560.00 |
| paragraph/render_wrap/64 | ➖ (view plot) | 180,760.00 |
| paragraph/render_wrap/65535 | ➖ (view plot) | 1,327,200.00 |
| paragraph/render_wrap_scroll_full/2048 | ➖ (view plot) | 220,770.00 |
| paragraph/render_wrap_scroll_full/64 | ➖ (view plot) | 181,580.00 |
| paragraph/render_wrap_scroll_full/65535 | ➖ (view plot) | 1,324,200.00 |
| rect_rows/rows/1024 | ➖ (view plot) | 483.42 |
| rect_rows/rows/16 | ➖ (view plot) | 7.49 |
| rect_rows/rows/65535 | ➖ (view plot) | 30,423.00 |
| sparkline/render/2048 | ➖ (view plot) | 117,920.00 |
| sparkline/render/256 | ➖ (view plot) | 116,960.00 |
| sparkline/render/64 | ➖ (view plot) | 36,748.00 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Displayimpl forTextintentionally omits a trailing newline for the final line. This logic wasn't working for single-line text though. I added an additional text case, which previously was failing and now passes.