Skip to content

docs: terminal.rs typo #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

docs: terminal.rs typo #1313

merged 1 commit into from
Aug 8, 2024

Conversation

mrjackwills
Copy link
Contributor

Fix typo for depreciated set_cursor method comment.

From aet_cursor_position to set_cursor_position

@mrjackwills
docs: terminal.rs typo
f4f9c83 
Fix typo for depreciated `set_cursor` method comment.

`aet_cursor_position` to `set_cursor_position`
@mrjackwills mrjackwills requested a review from a team as a code owner August 7, 2024 21:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

🐰Bencher

ReportWed, August 7, 2024 at 21:58:01 UTC
ProjectRatatui
Branch1313/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
barchart/render/2048➖ (view plot)190,650.00
barchart/render/256➖ (view plot)122,810.00
barchart/render/64➖ (view plot)80,086.00
barchart/render_grouped/2048➖ (view plot)336,280.00
barchart/render_grouped/256➖ (view plot)134,130.00
barchart/render_grouped/64➖ (view plot)121,560.00
barchart/render_horizontal/2048➖ (view plot)162,010.00
barchart/render_horizontal/256➖ (view plot)80,011.00
barchart/render_horizontal/64➖ (view plot)74,170.00
block/render_all_feature/100x50➖ (view plot)10,023.00
block/render_all_feature/200x50➖ (view plot)18,198.00
block/render_all_feature/256x256➖ (view plot)86,058.00
block/render_empty/100x50➖ (view plot)5,575.50
block/render_empty/200x50➖ (view plot)11,348.00
block/render_empty/256x256➖ (view plot)72,766.00
buffer/empty/16➖ (view plot)790.44
buffer/empty/255➖ (view plot)225,260.00
buffer/empty/64➖ (view plot)13,040.00
buffer/filled/16➖ (view plot)792.46
buffer/filled/255➖ (view plot)229,300.00
buffer/filled/64➖ (view plot)13,336.00
buffer/with_lines/16➖ (view plot)8,937.70
buffer/with_lines/255➖ (view plot)8,536.50
buffer/with_lines/64➖ (view plot)9,328.80
line_render/Center/0➖ (view plot)4.02
line_render/Center/10➖ (view plot)438.55
line_render/Center/3➖ (view plot)230.09
line_render/Center/4➖ (view plot)255.25
line_render/Center/42➖ (view plot)557.05
line_render/Center/6➖ (view plot)275.27
line_render/Center/7➖ (view plot)309.17
line_render/Left/0➖ (view plot)4.02
line_render/Left/10➖ (view plot)392.94
line_render/Left/3➖ (view plot)157.34
line_render/Left/4➖ (view plot)171.73
line_render/Left/42➖ (view plot)557.30
line_render/Left/6➖ (view plot)261.13
line_render/Left/7➖ (view plot)273.01
line_render/Right/0➖ (view plot)4.02
line_render/Right/10➖ (view plot)394.52
line_render/Right/3➖ (view plot)229.11
line_render/Right/4➖ (view plot)272.03
line_render/Right/42➖ (view plot)613.81
line_render/Right/6➖ (view plot)348.54
line_render/Right/7➖ (view plot)391.64
list/render/16384➖ (view plot)1,156,800.00
list/render/2048➖ (view plot)268,700.00
list/render/64➖ (view plot)145,080.00
list/render_scroll_half/16384➖ (view plot)1,161,900.00
list/render_scroll_half/2048➖ (view plot)267,420.00
list/render_scroll_half/64➖ (view plot)99,065.00
paragraph/new/2048➖ (view plot)252,770.00
paragraph/new/64➖ (view plot)6,587.40
paragraph/new/65535➖ (view plot)8,001,100.00
paragraph/render/2048➖ (view plot)444,880.00
paragraph/render/64➖ (view plot)405,650.00
paragraph/render/65535➖ (view plot)1,645,700.00
paragraph/render_scroll_full/2048➖ (view plot)405,210.00
paragraph/render_scroll_full/64➖ (view plot)432,510.00
paragraph/render_scroll_full/65535➖ (view plot)1,616,100.00
paragraph/render_scroll_half/2048➖ (view plot)405,300.00
paragraph/render_scroll_half/64➖ (view plot)435,420.00
paragraph/render_scroll_half/65535➖ (view plot)1,616,800.00
paragraph/render_wrap/2048➖ (view plot)227,800.00
paragraph/render_wrap/64➖ (view plot)188,260.00
paragraph/render_wrap/65535➖ (view plot)1,428,300.00
paragraph/render_wrap_scroll_full/2048➖ (view plot)227,140.00
paragraph/render_wrap_scroll_full/64➖ (view plot)187,890.00
paragraph/render_wrap_scroll_full/65535➖ (view plot)1,439,400.00
rect_rows/rows/1024➖ (view plot)322.97
rect_rows/rows/16➖ (view plot)5.24
rect_rows/rows/65535➖ (view plot)20,305.00
sparkline/render/2048➖ (view plot)122,440.00
sparkline/render/256➖ (view plot)116,780.00
sparkline/render/64➖ (view plot)37,773.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

EdJoPaTo
EdJoPaTo approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@EdJoPaTo EdJoPaTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@joshka joshka merged commit 3fdb5e8 into ratatui:main Aug 8, 2024
39 checks passed
@mrjackwills mrjackwills deleted the patch-1 branch August 8, 2024 12:08
joshka pushed a commit to erak/ratatui that referenced this pull request Oct 14, 2024
@mrjackwills @joshka
docs: fix typo in terminal.rs (ratatui#1313)
7ae767a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

+1 more reviewer

@EdJoPaTo EdJoPaTo EdJoPaTo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrjackwills @joshka @EdJoPaTo