fix(no_std): propagate std feature flag to dependencies
#1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2025
Merged
|
This requires #1840 to compile properly (that's why tests fail). |
joshka
approved these changes
May 13, 2025
joshka
pushed a commit
to MatrixFrog/ratatui
that referenced
this pull request
May 15, 2025
Disables `std` feature flags in dependencies and only enables them with `ratatui` and `ratatui-core`'s `std` feature flag. This partially fixes the issue of still depending on `std`, when `std` feature flag is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables
stdfeature flags in dependencies and only enables them withratatuiandratatui-core'sstdfeature flag.Additionally bumps version of(moved to #1844), to get upstream changes that allow disabling dependency onkasuaristd.This partially fixes the issue of still depending on
std, whenstdfeature flag is disabled.