-
-
Notifications
You must be signed in to change notification settings - Fork 461
feat: Add color to rat logo #1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I feel indifferent about adding a color to the rat, but we are going to add a color there's a couple of considerations:
|
I didn't like going too grey on the rat. Take a look at the colors on the actual rat logo on the website for some ideas. It took a while to find the right grey there, but we stuck with white on the demo. |
I don't think adding colors to that demo is necessary.
This one is a demo/example rather than a widget. We should probably rename that already existing widget to |
I think that the logo is the Ratatui word, while the Rat holding the terminal is the mascot. That's kinda how I think of it at least (and could be wrong here). |
Yeah, that also makes sense if we think that way. Then how about adding this mascot as Though I'm not sure if that's super useful. It could be nice just as a gag. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
=======================================
- Coverage 93.0% 92.9% -0.2%
=======================================
Files 72 76 +4
Lines 16830 17176 +346
=======================================
+ Hits 15660 15960 +300
- Misses 1170 1216 +46 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few comments. Much of these are in the subjective bucket rather than necessary, which might generally be seen as a bit nitpicky, but I'm pushing for them here because this task is mostly in the same bucket. I hope you're ok with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work getting this working. I have some small simplifications / fixes noted.
Also, I don't recall when / why the rat moved to the right side. It wasn't part of this PR, but it looks a bit odd. Perhaps flip it back to the left side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of last bits.
Some context on the generation of this demo btw. There was a whole tonne of back and forth between @kdheepak and I one random evening tweaking a whole tonne of things (colors, pixels, etc.) a while back to celebrate #500 and then a collaboration of a bunch of different people helped make it look even better.
Then we added the destroy function function for commit 1000 in the repo.
We just missed commit / PR 1500 with this change which is a bit of a bummer, but c'est la vie.
Slapping an approval on this. If the other maintainers want to chime in on any last minute changes, feel free, but I think this is mostly good at this point (with some small nits).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello I've updated the code with corrections :) |
Thanks for sticking with this to get it over the line. This is one of those changes that definitely was always going to have some back and forth due to the subjective nature, and I appreciate you for the work you spent getting it over the line. |
Why doesn't the logo have color ?
Original changed mascot
Another question: Why does this logo isn't in
ratatui::widgets::RatatuiLogo
?Updated masot widget