Skip to content

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Dec 22, 2024

Why doesn't the logo have color ?

Original changed mascot

image

Another question: Why does this logo isn't in ratatui::widgets::RatatuiLogo?

Updated masot widget

image

@Its-Just-Nans Its-Just-Nans requested a review from a team as a code owner December 22, 2024 12:06
@Its-Just-Nans Its-Just-Nans changed the title Add color to rat logo feat:Add color to rat logo Dec 22, 2024
@Its-Just-Nans Its-Just-Nans changed the title feat:Add color to rat logo feat: Add color to rat logo Dec 22, 2024
@kdheepak
Copy link
Collaborator

kdheepak commented Dec 22, 2024

I feel indifferent about adding a color to the rat, but we are going to add a color there's a couple of considerations:

  1. It should work in both a light and dark theme on the website.
  2. It should have good contrast to the background in both cases

@joshka
Copy link
Member

joshka commented Dec 23, 2024

I didn't like going too grey on the rat. Take a look at the colors on the actual rat logo on the website for some ideas. It took a while to find the right grey there, but we stuck with white on the demo.

@orhun
Copy link
Member

orhun commented Dec 23, 2024

I don't think adding colors to that demo is necessary.

Another question: Why does this logo isn't in ratatui::widgets::RatatuiLogo?

This one is a demo/example rather than a widget.

We should probably rename that already existing widget to RatatuiTextLogo or RatatuiText and add the rat logo as RatatuiLogo.

@joshka
Copy link
Member

joshka commented Dec 23, 2024

I think that the logo is the Ratatui word, while the Rat holding the terminal is the mascot. That's kinda how I think of it at least (and could be wrong here).

@orhun
Copy link
Member

orhun commented Dec 23, 2024

Yeah, that also makes sense if we think that way. Then how about adding this mascot as RatatuiMascot widget (or even just Rat :D)

Though I'm not sure if that's super useful. It could be nice just as a gag.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 99.09091% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.9%. Comparing base (03066d8) to head (17f90b5).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
ratatui-widgets/src/mascot.rs 99.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1584     +/-   ##
=======================================
- Coverage   93.0%   92.9%   -0.2%     
=======================================
  Files         72      76      +4     
  Lines      16830   17176    +346     
=======================================
+ Hits       15660   15960    +300     
- Misses      1170    1216     +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few comments. Much of these are in the subjective bucket rather than necessary, which might generally be seen as a bit nitpicky, but I'm pushing for them here because this task is mostly in the same bucket. I hope you're ok with that.

@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Dec 24, 2024

Thanks for the great review

Here is the updated code with the updated result

image

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work getting this working. I have some small simplifications / fixes noted.

Also, I don't recall when / why the rat moved to the right side. It wasn't part of this PR, but it looks a bit odd. Perhaps flip it back to the left side?

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of last bits.

Some context on the generation of this demo btw. There was a whole tonne of back and forth between @kdheepak and I one random evening tweaking a whole tonne of things (colors, pixels, etc.) a while back to celebrate #500 and then a collaboration of a bunch of different people helped make it look even better.

Then we added the destroy function function for commit 1000 in the repo.

We just missed commit / PR 1500 with this change which is a bit of a bummer, but c'est la vie.

Slapping an approval on this. If the other maintainers want to chime in on any last minute changes, feel free, but I think this is mostly good at this point (with some small nits).

Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Its-Just-Nans
Copy link
Contributor Author

Hello

I've updated the code with corrections :)

@Its-Just-Nans Its-Just-Nans requested a review from joshka December 26, 2024 10:07
@joshka
Copy link
Member

joshka commented Dec 26, 2024

LGTM - I pushed a last change to make the terminal border color 237 because it's (close enough to) the dark mode color for macOS borders.

image

@joshka joshka merged commit 50ba965 into ratatui:main Dec 26, 2024
31 checks passed
@joshka
Copy link
Member

joshka commented Dec 26, 2024

Thanks for sticking with this to get it over the line. This is one of those changes that definitely was always going to have some back and forth due to the subjective nature, and I appreciate you for the work you spent getting it over the line.

This was referenced Feb 11, 2025
This was referenced Mar 3, 2025
@github-actions github-actions bot mentioned this pull request May 14, 2025
@github-actions github-actions bot mentioned this pull request May 20, 2025
@j-g00da j-g00da mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants