Skip to content

feat(example): add drawing feature to the canvas example #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2024
Merged

feat(example): add drawing feature to the canvas example #1429

merged 3 commits into from
Oct 20, 2024

Conversation

orhun
Copy link
Member

@orhun orhun commented Oct 18, 2024

rec_20241018T235208

fun fact: I had to do 35 pushups for this...

@orhun orhun requested a review from a team as a code owner October 18, 2024 20:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

🐰 Bencher Report

Branch1429/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
barchart/render/2048📈 view plot
⚠️ NO THRESHOLD		196,090.00
barchart/render/256📈 view plot
⚠️ NO THRESHOLD		129,380.00
barchart/render/64📈 view plot
⚠️ NO THRESHOLD		84,305.00
barchart/render_grouped/2048📈 view plot
⚠️ NO THRESHOLD		344,700.00
barchart/render_grouped/256📈 view plot
⚠️ NO THRESHOLD		140,480.00
barchart/render_grouped/64📈 view plot
⚠️ NO THRESHOLD		128,300.00
barchart/render_horizontal/2048📈 view plot
⚠️ NO THRESHOLD		166,580.00
barchart/render_horizontal/256📈 view plot
⚠️ NO THRESHOLD		83,250.00
barchart/render_horizontal/64📈 view plot
⚠️ NO THRESHOLD		76,971.00
block/render_all_feature/100x50📈 view plot
⚠️ NO THRESHOLD		11,348.00
block/render_all_feature/200x50📈 view plot
⚠️ NO THRESHOLD		19,671.00
block/render_all_feature/256x256📈 view plot
⚠️ NO THRESHOLD		93,667.00
block/render_empty/100x50📈 view plot
⚠️ NO THRESHOLD		6,224.20
block/render_empty/200x50📈 view plot
⚠️ NO THRESHOLD		12,138.00
block/render_empty/256x256📈 view plot
⚠️ NO THRESHOLD		79,726.00
buffer/empty/16📈 view plot
⚠️ NO THRESHOLD		793.98
buffer/empty/255📈 view plot
⚠️ NO THRESHOLD		221,490.00
buffer/empty/64📈 view plot
⚠️ NO THRESHOLD		13,418.00
buffer/filled/16📈 view plot
⚠️ NO THRESHOLD		779.53
buffer/filled/255📈 view plot
⚠️ NO THRESHOLD		218,320.00
buffer/filled/64📈 view plot
⚠️ NO THRESHOLD		13,134.00
buffer/with_lines/16📈 view plot
⚠️ NO THRESHOLD		14,787.00
buffer/with_lines/255📈 view plot
⚠️ NO THRESHOLD		15,041.00
buffer/with_lines/64📈 view plot
⚠️ NO THRESHOLD		13,784.00
line_render/Center/0📈 view plot
⚠️ NO THRESHOLD		4.02
line_render/Center/10📈 view plot
⚠️ NO THRESHOLD		628.71
line_render/Center/3📈 view plot
⚠️ NO THRESHOLD		298.66
line_render/Center/4📈 view plot
⚠️ NO THRESHOLD		342.23
line_render/Center/42📈 view plot
⚠️ NO THRESHOLD		849.84
line_render/Center/6📈 view plot
⚠️ NO THRESHOLD		400.01
line_render/Center/7📈 view plot
⚠️ NO THRESHOLD		455.75
line_render/Left/0📈 view plot
⚠️ NO THRESHOLD		4.02
line_render/Left/10📈 view plot
⚠️ NO THRESHOLD		597.83
line_render/Left/3📈 view plot
⚠️ NO THRESHOLD		230.71
line_render/Left/4📈 view plot
⚠️ NO THRESHOLD		245.42
line_render/Left/42📈 view plot
⚠️ NO THRESHOLD		847.04
line_render/Left/6📈 view plot
⚠️ NO THRESHOLD		389.74
line_render/Left/7📈 view plot
⚠️ NO THRESHOLD		404.20
line_render/Right/0📈 view plot
⚠️ NO THRESHOLD		4.02
line_render/Right/10📈 view plot
⚠️ NO THRESHOLD		569.28
line_render/Right/3📈 view plot
⚠️ NO THRESHOLD		275.71
line_render/Right/4📈 view plot
⚠️ NO THRESHOLD		331.57
line_render/Right/42📈 view plot
⚠️ NO THRESHOLD		849.04
line_render/Right/6📈 view plot
⚠️ NO THRESHOLD		444.15
line_render/Right/7📈 view plot
⚠️ NO THRESHOLD		501.95
list/render/16384📈 view plot
⚠️ NO THRESHOLD		1,216,000.00
list/render/2048📈 view plot
⚠️ NO THRESHOLD		330,610.00
list/render/64📈 view plot
⚠️ NO THRESHOLD		209,410.00
list/render_scroll_half/16384📈 view plot
⚠️ NO THRESHOLD		1,224,700.00
list/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		336,470.00
list/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		140,850.00
paragraph/new/2048📈 view plot
⚠️ NO THRESHOLD		255,810.00
paragraph/new/64📈 view plot
⚠️ NO THRESHOLD		6,917.60
paragraph/new/65535📈 view plot
⚠️ NO THRESHOLD		8,099,400.00
paragraph/render/2048📈 view plot
⚠️ NO THRESHOLD		618,270.00
paragraph/render/64📈 view plot
⚠️ NO THRESHOLD		576,980.00
paragraph/render/65535📈 view plot
⚠️ NO THRESHOLD		1,684,600.00
paragraph/render_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		594,130.00
paragraph/render_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		631,010.00
paragraph/render_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,657,100.00
paragraph/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		594,150.00
paragraph/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		630,330.00
paragraph/render_scroll_half/65535📈 view plot
⚠️ NO THRESHOLD		1,654,100.00
paragraph/render_wrap/2048📈 view plot
⚠️ NO THRESHOLD		289,040.00
paragraph/render_wrap/64📈 view plot
⚠️ NO THRESHOLD		257,110.00
paragraph/render_wrap/65535📈 view plot
⚠️ NO THRESHOLD		1,387,300.00
paragraph/render_wrap_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		288,250.00
paragraph/render_wrap_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		257,030.00
paragraph/render_wrap_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,382,300.00
rect/rect_columns_collect/16📈 view plot
⚠️ NO THRESHOLD		38.85
rect/rect_columns_collect/255📈 view plot
⚠️ NO THRESHOLD		291.68
rect/rect_columns_collect/64📈 view plot
⚠️ NO THRESHOLD		89.55
rect/rect_columns_iter/16📈 view plot
⚠️ NO THRESHOLD		9.71
rect/rect_columns_iter/255📈 view plot
⚠️ NO THRESHOLD		84.13
rect/rect_columns_iter/64📈 view plot
⚠️ NO THRESHOLD		26.23
rect/rect_positions_collect/16x16📈 view plot
⚠️ NO THRESHOLD		294.58
rect/rect_positions_collect/255x255📈 view plot
⚠️ NO THRESHOLD		60,538.00
rect/rect_positions_collect/64x64📈 view plot
⚠️ NO THRESHOLD		3,875.70
rect/rect_positions_iter/16x16📈 view plot
⚠️ NO THRESHOLD		248.89
rect/rect_positions_iter/255x255📈 view plot
⚠️ NO THRESHOLD		60,348.00
rect/rect_positions_iter/64x64📈 view plot
⚠️ NO THRESHOLD		3,814.60
rect/rect_rows_collect/16📈 view plot
⚠️ NO THRESHOLD		39.62
rect/rect_rows_collect/255📈 view plot
⚠️ NO THRESHOLD		291.97
rect/rect_rows_collect/64📈 view plot
⚠️ NO THRESHOLD		90.68
rect/rect_rows_iter/16📈 view plot
⚠️ NO THRESHOLD		7.91
rect/rect_rows_iter/255📈 view plot
⚠️ NO THRESHOLD		80.65
rect/rect_rows_iter/64📈 view plot
⚠️ NO THRESHOLD		21.55
sparkline/render/2048📈 view plot
⚠️ NO THRESHOLD		130,650.00
sparkline/render/256📈 view plot
⚠️ NO THRESHOLD		129,660.00
sparkline/render/64📈 view plot
⚠️ NO THRESHOLD		41,175.00
table/render/16384x2📈 view plot
⚠️ NO THRESHOLD		2,899,000.00
table/render/16384x4📈 view plot
⚠️ NO THRESHOLD		5,646,100.00
table/render/16384x8📈 view plot
⚠️ NO THRESHOLD		17,870,000.00
table/render/2048x2📈 view plot
⚠️ NO THRESHOLD		641,290.00
table/render/2048x4📈 view plot
⚠️ NO THRESHOLD		1,103,700.00
table/render/2048x8📈 view plot
⚠️ NO THRESHOLD		1,813,500.00
table/render/64x2📈 view plot
⚠️ NO THRESHOLD		350,510.00
table/render/64x4📈 view plot
⚠️ NO THRESHOLD		526,290.00
table/render/64x8📈 view plot
⚠️ NO THRESHOLD		599,020.00
table/render_scroll_half/16384x2📈 view plot
⚠️ NO THRESHOLD		2,885,200.00
table/render_scroll_half/16384x4📈 view plot
⚠️ NO THRESHOLD		5,828,300.00
table/render_scroll_half/16384x8📈 view plot
⚠️ NO THRESHOLD		20,302,000.00
table/render_scroll_half/2048x2📈 view plot
⚠️ NO THRESHOLD		655,390.00
table/render_scroll_half/2048x4📈 view plot
⚠️ NO THRESHOLD		1,103,400.00
table/render_scroll_half/2048x8📈 view plot
⚠️ NO THRESHOLD		1,797,100.00
table/render_scroll_half/64x2📈 view plot
⚠️ NO THRESHOLD		230,270.00
table/render_scroll_half/64x4📈 view plot
⚠️ NO THRESHOLD		341,370.00
table/render_scroll_half/64x8📈 view plot
⚠️ NO THRESHOLD		388,040.00
🐰 View full continuous benchmarking report in Bencher

joshka
joshka approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just style nits

@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.5%. Comparing base (4f5503d) to head (fdc6276).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #1429   +/-   ##
=====================================
  Coverage   93.5%   93.5%           
=====================================
  Files         68      68           
  Lines      16875   16875           
=====================================
  Hits       15782   15782           
  Misses      1093    1093

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka merged commit 4c4851c into ratatui:main Oct 20, 2024
39 of 40 checks passed
@orhun
Copy link
Member Author

orhun commented Oct 20, 2024

Thanks for making the changes :)

@orhun orhun mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhun @joshka