Fix BigInt::random_integer logic that can cause slow execution #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We maintain a distinct codepath for the case where min is 0 or 1, since otherwise certain tests which expect stability of this function will break. If min is > 1, we generate a number in the range `min + [0,max-min)`, which avoids the slow case. Fixes #3590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a distinct codepath for the case where min is 0 or 1, since otherwise certain tests which expect stability of this function will break.
If min is > 1, we generate a number in the range
min + [0,max-min), which avoids the slow case.Fixes #3590