Skip to content

[RFE] Add optional filter on AzureAD auth group memberships #42940

@samjustus

Description

@samjustus

Describe the solution you'd like
we have many users that have a lot of groups and we have discovered that it generates a lot of logs because all of their groups are displayed in the logs. We would like to use a filter so that only groups that begins with a specific name are being returned instead of all the groups the user has attached to his account. We saw in the function below that there is a filter option available to could help us reduce the number of groups being fetch.

// ListGroups fetches all group principals in a directory from the Microsoft Graph API. func (c azureMSGraphClient) ListGroups(filter string) ([]v3.Principal, error) { groups, _, err := c.groupClient.List(context.Background(), odata.Query{Filter: filter}) var principals []v3.Principal for _, u := range *groups { principal, err := c.groupToPrincipal(u) if err != nil { return nil, err } principals = append(principals, principal) } return principals, err }

We also suspect this impact the performance of rancher and we would like know what would you recommand to fix this?

Additional context
we have many users that have a lot of groups and we have discovered that it generates a lot of logs because all of their groups are displayed in the logs.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions