Add a Parameter to Configure Worker count for fleet-controller #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
reviewed
May 15, 2024
| @@ -64,6 +64,18 @@ spec: | |||
| - name: CATTLE_DEV_MODE | |||
| value: "true" | |||
| {{- end }} | |||
| {{- if $.Values.controller.reconciler.workers.gitrepo }} | |||
| - name: CONTROLLER_GITREPO_RECONCILER_WORKERS | |||
There was a problem hiding this comment.
Suggested change
| - name: CONTROLLER_GITREPO_RECONCILER_WORKERS | |
| - name: GITREPO_RECONCILER_WORKERS |
I'd remove the controller prefix on all envs, for brevity.
There was a problem hiding this comment.
Just changed this TY Mario !
manno
reviewed
May 15, 2024
charts/fleet/values.yaml
Outdated
| workers: | ||
| gitrepo: "1" | ||
| bundle: "2" | ||
| bundledeployment: "3" |
There was a problem hiding this comment.
Suggested change
| bundledeployment: "3" | |
| bundledeployment: "1" |
I'd default them all to 1, I think that's the upstream default, too.
There was a problem hiding this comment.
Of course, I forgot to reset them !
manno
requested changes
May 15, 2024
internal/cmd/controller/root.go
Outdated
| @@ -54,6 +54,12 @@ type LeaderElectionOptions struct { | |||
| RetryPeriod *time.Duration | |||
| } | |||
|
|
|||
| type ControllerReconcilerWorkers struct { | |||
| Gitrepo int | |||
There was a problem hiding this comment.
I just noticed it's GitRepo everywhere else
Suggested change
| Gitrepo int | |
| GitRepo int |
internal/cmd/controller/root.go
Outdated
| type ControllerReconcilerWorkers struct { | ||
| Gitrepo int | ||
| Bundle int | ||
| Bundledeployment int |
There was a problem hiding this comment.
Suggested change
| Bundledeployment int | |
| BundleDeployment int |
manno
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2415
Added a new environment var for each type of reconciler (gitrepo, bundle, bundledeployment) to configure their worker count (in values.yaml)
No test for this, we need a large scale fleet to test to test it