Skip to content

GHA migration: secrets check #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2024
Merged

GHA migration: secrets check #365

merged 2 commits into from
Apr 24, 2024

Conversation

enrichman
Copy link
Contributor

This PR adds the steps that will use the migrated secrets, and a release.yml workflow that will be used for the releases.

The FOSSA secret with the API key is used during the CI workflow.
The Docker Hub username and password will be used during the release. At the moment we are just going to login to see that they are working fine.

This PR is needed because the branched of the CLI repo are protected, and we need PRs for them.
This is a first step "soft" PR used for the migration with no side-effects.

@enrichman enrichman self-assigned this Apr 24, 2024
@enrichman enrichman force-pushed the 44987-v2.9-gha-migration-test branch from f77c30f to 7d7f4e8 Compare April 24, 2024 13:40
@enrichman enrichman mentioned this pull request Apr 24, 2024
Closed
andreas-kupries
andreas-kupries requested changes Apr 24, 2024
View reviewed changes
@enrichman
Copy link
Contributor Author

Thanks for the review @andreas-kupries . I checked with @Anarkis and the error is expected because of the run on a different repo. Once merged we can check that the secrets are ok.
Do you think I should open the PR on a different branch? It's safe to merge on purpose.

@andreas-kupries
Copy link

Thanks for the review @andreas-kupries . I checked with @Anarkis and the error is expected because of the run on a different repo. Once merged we can check that the secrets are ok. Do you think I should open the PR on a different branch? It's safe to merge on purpose.

For my migration I actually did a test PR on a non-forked branch to check that the creds worked, and, of course the actions after also. For the FOSSA this might not be as important, as it is a code check, and not pushing anything.

bigkevmcd
bigkevmcd approved these changes Apr 24, 2024
View reviewed changes
Copy link

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@enrichman enrichman merged commit a85cc10 into rancher:v2.9 Apr 24, 2024
@enrichman
Copy link
Contributor Author

Secrets are working fine 👍

@enrichman enrichman mentioned this pull request Apr 29, 2024
Merged
@enrichman enrichman linked an issue Apr 30, 2024 that may be closed by this pull request
Migrate rancher/cli from Drone to GH Actions rancher/rancher#44987
Closed
@enrichman enrichman deleted the 44987-v2.9-gha-migration-test branch August 20, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-kupries andreas-kupries andreas-kupries approved these changes

@bigkevmcd bigkevmcd bigkevmcd approved these changes

@crobby crobby Awaiting requested review from crobby

Assignees

@enrichman enrichman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate rancher/cli from Drone to GH Actions
3 participants
@enrichman @andreas-kupries @bigkevmcd