Skip to content

Fix panics in rancher token and rancher server current commands #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix panics in rancher token and rancher server current commands #348

merged 1 commit into from
Feb 8, 2024

Conversation

enrichman
Copy link
Contributor

Fix rancher/rancher#44332

As I've moved in this PR only the fix related to the panics. I'm going to then rebase the other PR.

Bug Description

Some workflows will trigger panics due to assignment to nil maps, or a missing check:

// sc.KubeCredentials is nil -> panics
sc.KubeCredentials[id] = cred
serverName := cf.CurrentServer
// missing check for the existance of the value -> panics
URL := cf.Servers[serverName].URL

To reproduce just run a rancher server current without any configuration:

-> % rancher server current 
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xa14869]

goroutine 1 [running]:
github.com/rancher/cli/cmd.serverCurrent(0xc000195b80?)
        /go/src/github.com/rancher/cli/cmd/server.go:74 +0xc9
github.com/urfave/cli.HandleAction({0xaa5b00?, 0xc28200?}, 0x7?)
...

or run a rancher login followed by a rancher token:

-> % rancher login https://myrancher.com --name https://myrancher.com --token MYTOKEN
INFO[0000] Saving config to /home/enrico/.rancher/cli2.json

###

-> % rancher token --server https://myrancher.com --user local
https://myrancher.com/v3-public/authProviders 
Enter credentials for localProvider 
 
Enter username: admin 
Enter password: 
panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/rancher/cli/cmd.cacheCredential(0xc000274160, 0xc00032a2d0, {0xc0003326a0, 0x6})
        /go/src/github.com/rancher/cli/cmd/kubectl_token.go:283 +0x11a
github.com/rancher/cli/cmd.runCredential(0xc000274160)
        /go/src/github.com/rancher/cli/cmd/kubectl_token.go:165 +0x4a5
github.com/urfave/cli.HandleAction({0xaa5b00?, 0xc281f0?}, 0xc00011cfc0?)
        /go/pkg/mod/github.com/urfave/cli@v1.22.5/app.go:524 +0x50
github.com/urfave/cli.(*App).RunAsSubcommand(0xc00011cfc0, 0xc000274000)
        /go/pkg/mod/github.com/urfave/cli@v1.22.5/app.go:410 +0xabd
github.com/urfave/cli.Command.startApp({{0xbd2fb4, 0x5}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xbf2956, 0x2e}, {0x0, ...}, ...}, ...)
        /go/pkg/mod/github.com/urfave/cli@v1.22.5/command.go:372 +0xb7f
github.com/urfave/cli.Command.Run({{0xbd2fb4, 0x5}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xbf2956, 0x2e}, {0x0, ...}, ...}, ...)
        /go/pkg/mod/github.com/urfave/cli@v1.22.5/command.go:102 +0x845
github.com/urfave/cli.(*App).Run(0xc00011ce00, {0xc00004fd00, 0x6, 0x8})
        /go/pkg/mod/github.com/urfave/cli@v1.22.5/app.go:277 +0xb67
main.mainErr()
        /go/src/github.com/rancher/cli/main.go:136 +0x1f5d
main.main()
        /go/src/github.com/rancher/cli/main.go:57 +0x19

@enrichman enrichman self-assigned this Feb 8, 2024
@enrichman enrichman requested a review from crobby February 8, 2024 10:02
@enrichman enrichman mentioned this pull request Feb 8, 2024
Closed
crobby
crobby approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I know the tests are coming in #347

@enrichman enrichman mentioned this pull request Feb 8, 2024
Open
andreas-kupries
andreas-kupries approved these changes Feb 8, 2024
View reviewed changes
Copy link

@andreas-kupries andreas-kupries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@enrichman enrichman merged commit a12fd3b into rancher:v2.9 Feb 8, 2024
@enrichman enrichman mentioned this pull request Feb 8, 2024
Merged
@anupama2501 anupama2501 mentioned this pull request Mar 15, 2024
Closed
@enrichman enrichman deleted the 44332-cli-panics branch August 20, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-kupries andreas-kupries andreas-kupries approved these changes

@crobby crobby crobby approved these changes

Assignees

@enrichman enrichman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CLI panics when trying to kubectl after a login
3 participants
@enrichman @andreas-kupries @crobby