Fix crash when active camera is in a scene that is freed #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramokz
reviewed
Mar 30, 2025
addons/phantom_camera/scripts/phantom_camera_host/phantom_camera_host.gd
Show resolved
Hide resolved
|
Merging this in for now and will look at a longer-term solution later on. Thanks again for the PR! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if you have one scene that has the active pcam and then that scene is freed.
In my case, I had a loading screen with a
PhantomCamera3Dthat gets freed and then replaced with the "real" scene.