feat: support insert_into_file erroring if the file is not changed, and add insert_into_file
#908
+197
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
commented
Jul 21, 2025
| @@ -2,6 +2,38 @@ | |||
|
|
|||
| class Thor | |||
| module Actions | |||
| WARNINGS = {unchanged_no_flag: "File unchanged! Either the supplied flag value not found or the content has already been inserted!"} | |||
There was a problem hiding this comment.
note: moving this is good anyway because it was the subject of the method comment intended for insert_into_file 😅
G-Rath
commented
Jul 21, 2025
| @@ -20,6 +20,10 @@ def invoke!(*args, &block) | |||
| capture(:stdout) { invoker.insert_into_file(*args, &block) } | |||
| end | |||
|
|
|||
| def invoke_with_a_bang!(*args, &block) | |||
There was a problem hiding this comment.
note: this seemed like the most straightforward, if a little whimsical, way of handling the tests
Happy to go with an alternative structure though if desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
Following on from #877, this adds a bang version of
insert_into_fileand its alias