Fix Ruby 3.2.0-dev CI #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft because I want to find a better way. |
Exception#detailed_message behaviour670d4df to
d9ec76b
Compare
Ruby 3.2 will introduce `Exception#detailed_message` and `did_you_mean` has been already updated in Ruby 3.2 to use that. The new behaviour means not changing the original `Exception#message`. That means it is hard to get the previous error output, because `Exception#detailed_message` includes not only `did_you_mean` decorations, but also additional information like the exception class. To fix this, I bring the old did_you_mean behavior into Thor, so that the above changes do not affect us.
|
Ok, I think the new approach is much cleaner, this should be ready! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.2 will introduce
Exception#detailed_messageanddid_you_meanhas been already updated in Ruby 3.2 to use that.The new behaviour means not changing the original
Exception#message. That means it is hard to get the previous error output, becauseException#detailed_messageincludes not onlydid_you_meandecorations, but also additional information like the exception class.My fix is to change the
Correctablemodule to essentially reimplement the old did_you_mean behavior, so that we can keep our behavior intact without getting affected by the above changes.Fixes #781.