🌈 More accurate Arguments#current_is_value? check #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense. Can you write the tests? |
test for array parsing of '-'
f6842ac to
873da2a
Compare
Comment on lines
+43
to
+47
| it "accepts - as an array argument" do | ||
| create :array => nil | ||
| expect(parse("-")["array"]).to eq(%w(-)) | ||
| expect(parse("-", "title", "-")["array"]).to eq(%w(- title -)) | ||
| end |
There was a problem hiding this comment.
I ran this test against master and, as expected, it fails. I don't think there's any other cases we need to consider for this feature.
I also went through the docs and feel like we don't need to update/change anything: IMO this change is to allow functionality that should already (implicitly) be present, not a new feature.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For a number of tools, the argument
-is often treated to mean STDIN. Currently, Thor is unable to accept-as an argument value, since it defines a flag as any entry beginning with-. This seems overly restrictive. I would argue that a flag is defined as follows:In regex terms, this is
/-{1,2}\S+/.TODO