Hey, great that you have looked into this. I'm a bit concerned about the fix because the regex assumes ~1 to proceed username but what about legitimate file paths that contain such characters? Also I would encourage you to write a test that demonstrates this problem/fix.

Hey Piotr, thanks for your feedback. I have a different approach to this now - replacing the file path that is created by Dir.glob with it's original stored in lookup. I also have it only performing the replacement when it sees a windows environment variable for username (which I can imagine is the only use case for this). I'll write a test before pushing it up, but that will be after work 😞 !

I'm questioning myself right now as to whether this is the right fix!! It is essentially a work around rather than a fix. For example, this issue could be remedied in this part on thor, or on rspec which is creating the tmpdir file path before it is sent to thor.

It is essentially Dir.glob(lookup, File::FNM_DOTMATCH) that is making the change from USER~1 to User Name, so is there another method that could replace this that doesn't make that change??

Ok, digging more unearths that this is something that has arisen since Ruby 2.3. See Ruby Issue #10819 referenced from Puppet pull-request #5156.

Also struggling to figure out what exactly I need to test for with this (I'm new to writing tests and all that!).

Any uodate in this

Any update on this? still can't run rspec:install on windows machine

Followed the work around and updated the file by my own and I'm able to continue working. Thanks @garrrth