Remove sass implicit dependency #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! That's exactly what I meant. Don't worry about Source Maps tests, I think it's expected to have some differences in the source maps between implementations. About the failure in TravisCI I think we can drop support for Ruby 2.2 since it's EOL'ed since last year |
guilleiguaran
approved these changes
Jan 21, 2019
Merged
|
Thanks @guilleiguaran, I created #593 to drop support for ruby 2.2 and thus get CI green. |
This was referenced Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do with I think @guilleiguaran meant by rails/rails#34884 (comment). Also changed the default ".sass" and ".scss" processors to be sassc instead of sass. Basically I copied the sass implementations and changed the
Sassspecific bits to useSassC.I had to change a couple of tests to get it green, not sure if I need to change something in the implementation instead?