Add support for Cache-Control request directives #55033
Merged
+249
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
b0eae55 to
e47f341
Compare
byroot
reviewed
May 13, 2025
actionpack/CHANGELOG.md
Outdated
|
|
||
| # Value directives | ||
| request.cache_control_directives.max_age # => integer or nil | ||
| request.cache_control_directives.max_stale # => integer or nil (or true for valueless max-stale) |
There was a problem hiding this comment.
This is a bit of a problem, users are likely to assume max_stale if truthy is an Integer and not handle true correct.
There was a problem hiding this comment.
Nevermind, I see max_stale_unlimited?. I suppose that is acceptable
byroot
reviewed
May 13, 2025
actionpack/CHANGELOG.md
Outdated
|
|
||
| # Value directives | ||
| request.cache_control_directives.max_age # => integer or nil | ||
| request.cache_control_directives.max_stale # => integer or nil (or true for valueless max-stale) |
There was a problem hiding this comment.
Nevermind, I see max_stale_unlimited?. I suppose that is acceptable
e47f341 to
5c9904d
Compare
Co-Authored-By: Jean Boussier <jean.boussier@gmail.com>
5c9904d to
55b54a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the HTTP Cache-Control request directives were not fully supported in Rails. According to RFC 9111, HTTP clients can use various cache control directives in their requests to control how caching is handled. This implementation adds comprehensive support for these directives, with special attention to the
max-staledirective which can be used with or without a value.Detail
This Pull Request changes the following:
CacheControlDirectivesclass that parses and provides access to HTTP Cache-Control request directivesno-cache,no-store,no-transform,only-if-cached)max-age,min-fresh,stale-if-error)max-staledirective which can appear both with a value (e.g.,max-stale=300) or without a value (indicating unlimited staleness)This enhancement allows Rails applications to better integrate with HTTP caching mechanisms and provides more control over how requests interact with cached resources.
Additional information
The implementation follows RFC 9111 (HTTP Caching): https://www.rfc-editor.org/rfc/rfc9111.html#name-cache-control
The
max-staledirective required special handling as it can appear without a value, in which case it indicates the client is willing to accept a response no matter how stale it is.This PR is a comprehensive implementation that incorporates feedback and suggestions from the previous PR Add support for Cache-Control: only-if-cached directive #55008. (@byroot )
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]