PoolConfig no longer keeps a reference to the connection class (attempt 3)
#54366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2025
3d0c70c to
b136497
Compare
djmb
reviewed
Jan 27, 2025
byroot
reviewed
Jan 27, 2025
d9779de to
7526312
Compare
byroot
reviewed
Jan 27, 2025
activerecord/lib/active_record/connection_adapters/pool_config.rb
Outdated
Show resolved
Hide resolved
f6c3b68 to
9ebeda0
Compare
Keeping a reference to the class caused subtle issues when combined with reloading in development. Instead, extend StringConnectionName to properly track `primary_class?` and cache that. Refactoring includes renaming `connection_class` to `connection_descriptor`, and renaming the StringConnectionName class to ConnectionDescriptor. Fixes rails#54343.
9ebeda0 to
2a90dbc
Compare
This was referenced Jan 27, 2025
rafaelfranca
pushed a commit
that referenced
this pull request
Jan 27, 2025
…ss-in-pool-config-v3 `PoolConfig` no longer keeps a reference to the connection class (attempt 3)
|
Backported to 8-0-stable since this is mostly an internal restructure to fix a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Alt to #54350 and #54349, fixes #54343
Detail
This is variation on #54349 that extends
ConnectionHandler::StringConnectionNameto trackprimary_class?, and introducesActiveRecord::Base.preventing_writes?that will accept a connection name and do the same thing thatcurrent_preventing_writesdoes on a record class.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]