Skip to content

Tweak Gemfile comment about Solid adapters #52925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2024
Merged

Tweak Gemfile comment about Solid adapters #52925

merged 1 commit into from
Sep 14, 2024

Conversation

jeromedalbert
Copy link
Contributor

Follow-up to 1ec7b1970f8.

Do not mention Action Cable in the Gemfile if the app was generated with --skip-action-cable.

@rails-bot rails-bot bot added the railties label Sep 14, 2024
@jeromedalbert jeromedalbert mentioned this pull request Sep 14, 2024
Merged
@jeromedalbert
Tweak Gemfile comment about Solid adapters
14e1a53 
Do not mention Action Cable if app was generated with
--skip-action-cable
@jeromedalbert jeromedalbert force-pushed the gemfile-solid-adapters-comment branch from 9322990 to 14e1a53 Compare September 14, 2024 06:35
@dhh dhh merged commit 0c54183 into rails:main Sep 14, 2024
3 checks passed
dhh added a commit that referenced this pull request Sep 14, 2024
@dhh
Merge branch 'main' into kamal-2
8e7efcd 
* main:
  Tweak Gemfile comment about Solid adapters (#52925)
  Do not set up cable DB if skipping action cable (#52923)
  Fixup enum schema methods' signature to accept kwargs
  Add if_not_exists option to add_enum_value
@jeromedalbert jeromedalbert deleted the gemfile-solid-adapters-comment branch September 14, 2024 19:10
DanielaVelasquez pushed a commit to DanielaVelasquez/rails that referenced this pull request Oct 3, 2024
@jeromedalbert @DanielaVelasquez
Tweak Gemfile comment about Solid adapters (rails#52925)
0f42dcd 
Do not mention Action Cable if app was generated with
--skip-action-cable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromedalbert @dhh