Skip solid_cable gem if skip_action_cable is set #52919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the failing test AppGeneratorTest#test_app_update_does_not_generate_action_cable_contents_when_skip_action_cable_is_given
|
That does look right to me, yes. Solid is a 3-way bundle, but if you skip cable, you should only get 2. |
dhh
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Skip solid_cable gem if skip_action_cable is set (#52919) Call prerecord in test parallelization Fix a documentation name mismatch in cookies.rb
dhh
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Skip solid_cable gem if skip_action_cable is set (#52919) Call prerecord in test parallelization Fix a documentation name mismatch in cookies.rb Revert "Assign id attributes first in Active Record attribute assignment" Do not populate CurrentAttributes#attributes when not using defaults Suppress a RuboCop offense after running `rails new` with `--devcontainer` Fix small typo for Solid Cable changelog [ci skip] (#52911) Use less queries when updating nested attributes Load routes in LazyRoutesSet#recognize_path Slim down the gem section for Solid Add Solid Cable (#52889) Fix syntax error in user.rb Improve Active Record Association Callbacks docs [ci skip] Assign id attributes first in Active Record attribute assignment Always separate config blocks with a CR Fixup tests for #52850 Replace "healthcheck" with "health check" in documentation. [ci-skip]
dhh
added a commit
that referenced
this pull request
Sep 14, 2024
* main: No new apps should be started with sprockets (#52887) Skip solid_cable gem if skip_action_cable is set (#52919) Call prerecord in test parallelization Fix a documentation name mismatch in cookies.rb Revert "Assign id attributes first in Active Record attribute assignment" Do not populate CurrentAttributes#attributes when not using defaults Suppress a RuboCop offense after running `rails new` with `--devcontainer`
4 tasks
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
This fixes the failing test AppGeneratorTest#test_app_update_does_not_generate_action_cable_contents_when_skip_action_cable_is_given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing test on main (probably as of the solid_cable 3.0 release a couple hours ago)
If this isn't the right fix please don't hesitate to revert.
cc @dhh @npezza93