Skip to content

Add Solid Cable #52889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add Solid Cable #52889

merged 2 commits into from
Sep 12, 2024

Conversation

dhh
Copy link
Member

@dhh dhh commented Sep 12, 2024

Solid Cable is the last piece before we can fully claim that Rails 8 only requires a database as a dependency to get access to all frameworks and functionality. Thanks to @npezza93 for the great work!

@brunoprietog
Copy link
Contributor

I guess we need to analyze how this conflicts with the turbo:install task. There redis is set as the adapter for Action Cable by default, both in production and development environments. Turbo won't work in the development environment with the async adapter because it doesn't allow broadcasts.

@dhh
Copy link
Member Author

dhh commented Sep 12, 2024

@brunoprietog Good point. Think we can maybe just use the inline adapter there.

@dhh dhh merged commit 7f660a7 into main Sep 12, 2024
4 of 5 checks passed
@dhh dhh deleted the add-solid-cable branch September 12, 2024 17:30
dhh added a commit that referenced this pull request Sep 12, 2024
* main:
  Add Solid Cable (#52889)
  Fix syntax error in user.rb
dhh added a commit that referenced this pull request Sep 13, 2024
* main:
  Skip solid_cable gem if skip_action_cable is set (#52919)
  Call prerecord in test parallelization
  Fix a documentation name mismatch in cookies.rb
  Revert "Assign id attributes first in Active Record attribute assignment"
  Do not populate CurrentAttributes#attributes when not using defaults
  Suppress a RuboCop offense after running `rails new` with `--devcontainer`
  Fix small typo for Solid Cable changelog [ci skip] (#52911)
  Use less queries when updating nested attributes
  Load routes in LazyRoutesSet#recognize_path
  Slim down the gem section for Solid
  Add Solid Cable (#52889)
  Fix syntax error in user.rb
  Improve Active Record Association Callbacks docs [ci skip]
  Assign id attributes first in Active Record attribute assignment
  Always separate config blocks with a CR
  Fixup tests for #52850
  Replace "healthcheck" with "health check" in documentation. [ci-skip]
DanielaVelasquez pushed a commit to DanielaVelasquez/rails that referenced this pull request Oct 3, 2024
* Add Solid Cable

Co-authored-by: Nick Pezza <pezza@hey.com>
@rodrigotoledo
Copy link

Normally, when I need to reflect changes after executing a job or service, and I'm using Turbo Streams to make the application truly live, I utilize Redis even in development. This allows me to open the console, jobs, execute commands, and see the changes reflected in the open connections (the users interacting with the application). However, if I switch to inline jobs, will that consume more memory? @dhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants