Enable query log tags by default on development env #51342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfranca thoughts? If this is approved, I will add tests and a CHANGELOG entry. |
|
We already have another feature doing the same in development |
|
@rafaelfranca |
|
Sounds good let's get this finished up. As a general direction, don't open draft PRs, they are just ignored, and I would actually go as far as automatically closing draft PRs. Either the PR is ready to be reviewed or send a message in the Rails forum. Our attention spam is very small, so if we see a draft PR we will just close the tab since it isn't ready and never come back. |
c0d08fe to
5da8395
Compare
|
@rafaelfranca Thanks for letting me know! I think this is finished now. Side note: should we add the guideline to not open draft PRs in the contributing docs? |
|
How do query logs interact with prepared statements? My understanding was the two were not compatible and all db adapters except MySQL will use prepared statements by default. |
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342
stevepolitodesign
added a commit
to thoughtbot/suspenders
that referenced
this pull request
Apr 5, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342 Co-authored-by: Steve Polito <stevepolito@hey.com>
stevepolitodesign
added a commit
to thoughtbot/suspenders
that referenced
this pull request
May 10, 2024
Creates generator to configure the development environment. Keeps parity with Rails as much as possible in an effort to avoid drift with Rails standards. It's possible a future release of Rails will alleviate us from having to do the following: - enable `active_model.i18n_customize_full_message` which is being addressed in [#50406][] - enable `active_record.query_log_tags_enabled` which is being addressed in [#51342][] [#50406]: rails/rails#50406 [#51342]: rails/rails#51342 Co-authored-by: Steve Polito <stevepolito@hey.com>
@skipkayhil They don't. See: #48631 |
|
@rafaelfranca this is probably good to go |
This can be used to trace troublesome SQL statements back to the application code that generated these statements.
Earlopain
added a commit
to Earlopain/rails
that referenced
this pull request
Nov 8, 2024
* rails#51831 * rails#51342 * rails#52887 Probably more, these are the ones I noticed.
Earlopain
added a commit
to Earlopain/rails
that referenced
this pull request
Nov 15, 2024
* rails#51831 * rails#51342 Probably more, these are the ones I noticed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This can be used to trace troublesome SQL statements back to the application code that generated these statements. I feel like this is a good default value that helps with debugging and code discovery.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]