Support PG unbounded inclusive date/time range #51920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinko
commented
May 27, 2024
| @@ -196,14 +196,14 @@ def test_timezone_awareness_endless_tzrange | |||
| time_string = Time.current.to_s | |||
| time = Time.zone.parse(time_string) | |||
|
|
|||
| record = PostgresqlRange.new(tstz_range: time_string...) | |||
| assert_equal time..., record.tstz_range | |||
| record = PostgresqlRange.new(tstz_range: time_string..) | |||
There was a problem hiding this comment.
This just aligns with the next test, which uses inclusion.
justinko
commented
May 27, 2024
| assert_equal_round_trip @first_range, :ts_range, nil..Time.public_send(tz, 2010, 1, 1, 14, 30, 0) | ||
| time = Time.public_send(::ActiveRecord.default_timezone, 2010, 1, 1, 14, 30, 0) | ||
|
|
||
| assert_equal_round_trip @first_range, :ts_range, time..nil |
There was a problem hiding this comment.
This is the key assertion. I'm assuming it was never added because the previous committer kept experiencing it being flipped from .. to ....
pean
reviewed
Jul 15, 2024
There was a problem hiding this comment.
This patch is very close to the solution I came up with myself while doing my own discovery and investigation of this problem and as far as I can tell this solution is good. I hope it is possible to get this into a release in a near future.
Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51745
Motivation / Background
Suppose you have a PG
tsrangecolumn namedmy_range. If you create a record withmy_range: (Time.current..)(inclusive), PG will insert the record with[my_range,], but behind the scenes it'll convert it to[my_range,), making it exclusive.The problem is when you
reloador retrieve the record, it'll bemy_range: (Time.current...)(exclusive).You can "force" inclusivity by using the timestamp value of
infinityon insertion:[my_range, infinity]And that's what this change does.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]